You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "bdeggleston (via GitHub)" <gi...@apache.org> on 2025/04/08 21:55:20 UTC
[PR] Fix mutation tracking startup [cassandra]
bdeggleston opened a new pull request, #4065:
URL: https://github.com/apache/cassandra/pull/4065
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix mutation tracking startup [cassandra]
Posted by "aratno (via GitHub)" <gi...@apache.org>.
aratno commented on code in PR #4065:
URL: https://github.com/apache/cassandra/pull/4065#discussion_r2034106494
##########
src/java/org/apache/cassandra/tcm/Startup.java:
##########
@@ -152,7 +152,8 @@ public static void initializeAsNonCmsNode(Function<Processor, Processor> wrapPro
LocalLog.LogSpec logSpec = LocalLog.logSpec()
.withStorage(LogStorage.SystemKeyspace)
.afterReplay(Startup::scrubDataDirectories,
- (metadata) -> StorageService.instance.registerMBeans())
+ (metadata) -> StorageService.instance.registerMBeans(),
+ MutationTrackingService.instance::start)
Review Comment:
MutationTrackingService depends on schema being ready (so we can initialize shards for tracked keyspaces) and internode messaging / native protocol messaging to not be started yet (so we don't receive queries). Any other dependencies for why it has to be started here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix mutation tracking startup [cassandra]
Posted by "bdeggleston (via GitHub)" <gi...@apache.org>.
bdeggleston commented on code in PR #4065:
URL: https://github.com/apache/cassandra/pull/4065#discussion_r2034130319
##########
src/java/org/apache/cassandra/tcm/Startup.java:
##########
@@ -152,7 +152,8 @@ public static void initializeAsNonCmsNode(Function<Processor, Processor> wrapPro
LocalLog.LogSpec logSpec = LocalLog.logSpec()
.withStorage(LogStorage.SystemKeyspace)
.afterReplay(Startup::scrubDataDirectories,
- (metadata) -> StorageService.instance.registerMBeans())
+ (metadata) -> StorageService.instance.registerMBeans(),
+ MutationTrackingService.instance::start)
Review Comment:
The reason for initializing it via TCM in the first place was because the local node id wasn't always available when we tried to start the tracking service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix mutation tracking startup [cassandra]
Posted by "bdeggleston (via GitHub)" <gi...@apache.org>.
bdeggleston closed pull request #4065: Fix mutation tracking startup
URL: https://github.com/apache/cassandra/pull/4065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org