[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179: macOS support for sim

[GitBox <gi...@apache.org>]

yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372481926
 
 

 ##########
 File path: tools/sethost.sh
 ##########
 @@ -244,9 +244,9 @@ echo "  Refreshing..."
 cd $nuttx || { echo "ERROR: failed to cd to $nuttx"; exit 1; }
 make clean_context 1>/dev/null 2>&1
 if [ "X${debug}" = "Xy" ]; then
-  make olddefconfig V=1
+  make olddefconfig V=1 || { echo "ERROR: failed to refresh"; exit 1; }
 else
-  make olddefconfig 1>/dev/null 2>&1
+  make olddefconfig 1>/dev/null || { echo "ERROR: failed to refresh"; exit 1; }
 
 Review comment:
   it's intentional to expose the errors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services