You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/13 12:27:24 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37828: [SPARK-40384][INFRA] Only do base image real in time build when infra dockerfile is changed

HyukjinKwon commented on code in PR #37828:
URL: https://github.com/apache/spark/pull/37828#discussion_r969558717


##########
.github/workflows/build_and_test.yml:
##########
@@ -87,6 +91,7 @@ jobs:
             sparkr=`./dev/is-changed.py -m sparkr`
             tpcds=`./dev/is-changed.py -m sql`
             docker=`./dev/is-changed.py -m docker-integration-tests`
+            infra_image=`./dev/is-changed.py -m infra-image`

Review Comment:
   hmmm .. actually quick question. would that still build the base image when there are other changes together with Dockerfile? Do we return true when `root` module is detected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org