You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by anandvnath <gi...@git.apache.org> on 2016/12/26 05:04:15 UTC
[GitHub] cordova-plugin-wkwebview-engine pull request #27: CB-12297 Support WKProcess...
GitHub user anandvnath opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
CB-12297 Support WKProcessPool for cookie sharing
### Platforms affected
iOS
### What does this PR do?
Adds a shared WKProcessPool via static factory and use it in the WKWebView created by this plugin. Any WKWebView created by cordova apps can utilize this shared WKProcessPool for enabling cookie sharing.
### What testing has been done on this change?
Added a unit test to check if the shared instance is correctly created. Testing the cookie sharing functionality is hard to do via unit test.
### Checklist
- [/] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [/] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [/] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anandvnath/cordova-plugin-wkwebview-engine master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 012afe0359bcb66b0221124b82e9f290dc60317e
Author: anand.v.nath@gmail.com <an...@gmail.com>
Date: 2016-12-23T08:43:22Z
Added shared WKProcessPool support.
commit 8d96f76ed56771726342a455136c3d387f4d6f04
Author: anand.v.nath@gmail.com <an...@gmail.com>
Date: 2016-12-23T09:18:52Z
README changes and minor correction in where WKProcessPool is added.
commit 7dbfc32beb749f2d9d5ef6ab922c5dec27c8a2f5
Author: anand.v.nath@gmail.com <an...@gmail.com>
Date: 2016-12-23T10:04:59Z
Correct license headers.
commit b536d8815dc738096d3c58a95d8d1722946cc112
Author: anand.v.nath@gmail.com <an...@gmail.com>
Date: 2016-12-26T04:41:21Z
Test case modified.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #27: CB-12297 Support WKProcessPool fo...
Posted by anandvnath <gi...@git.apache.org>.
Github user anandvnath commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
Rebase done, CI is passing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #27: CB-12297 Support WKProcessPool fo...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
The next release perhaps in the next two weeks since I will be away next week. I'm trying to fix the CI failures for this repo first (they pass when manually run).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request #27: CB-12297 Support WKProcess...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #27: CB-12297 Support WKProcessPool fo...
Posted by anandvnath <gi...@git.apache.org>.
Github user anandvnath commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
@shazron Thanks for approving this.
Appreciate any updates on when you are planning to make this fix available?
Thanks
Anand
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #27: CB-12297 Support WKProcessPool fo...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/27
I've fixed the CI problem and would like this PR to be green before I pull it in. Can you rebase? It should re-test the PR automatically after.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org