You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/04/01 04:08:18 UTC
Re: Review Request 45083: Added a any mechanism for futures.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
-----------------------------------------------------------
(Updated April 1, 2016, 2:08 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebase.
Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038
Repository: mesos
Description
-------
Added a any mechanism for futures.
Diffs (updated)
-----
3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
Diff: https://reviews.apache.org/r/45083/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
-----------------------------------------------------------
(Updated April 16, 2016, 10:12 a.m.)
Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
Changes
-------
Rebase.
Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038
Repository: mesos
Description
-------
Added ANY mode to futures collect mechanism.
Diffs (updated)
-----
3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
Diff: https://reviews.apache.org/r/45083/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
-----------------------------------------------------------
(Updated April 13, 2016, 6:43 p.m.)
Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
Changes
-------
Rebase.
Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038
Repository: mesos
Description
-------
Added ANY mode to futures collect mechanism.
Diffs (updated)
-----
3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
Diff: https://reviews.apache.org/r/45083/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
-----------------------------------------------------------
(Updated April 10, 2016, 2:42 p.m.)
Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
Changes
-------
Fix @lins05's comment.
Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038
Repository: mesos
Description
-------
Added ANY mode to futures collect mechanism.
Diffs (updated)
-----
3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
Diff: https://reviews.apache.org/r/45083/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Posted by Shuai Lin <li...@gmail.com>.
> On April 8, 2016, 6:41 a.m., Shuai Lin wrote:
> > 3rdparty/libprocess/include/process/collect.hpp, line 217
> > <https://reviews.apache.org/r/45083/diff/8/?file=1329609#file1329609line217>
> >
> > Got a compile error here:
> >
> >
> > ```
> > In file included from ../../../3rdparty/libprocess/src/metrics/metrics.cpp:19:
> > ../../../3rdparty/libprocess/include/process/collect.hpp:216:24: error: redefinition of default argument
> > const CollectMode& mode = CollectMode::ALL)
> > ^ ~~~~~~~~~~~~~~~~
> > ../../../3rdparty/libprocess/include/process/collect.hpp:51:24: note: previous definition is here
> > const CollectMode& mode = CollectMode::ALL);
> > ```
> >
> > After remvoe the default argument value in line 216 it compiles ok.
On ubuntu with g++ it works fine, but fails on osx with clang.
- Shuai
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/#review127744
-----------------------------------------------------------
On April 7, 2016, 10:36 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45083/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 10:36 a.m.)
>
>
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-5038
> https://issues.apache.org/jira/browse/MESOS-5038
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ANY mode to futures collect mechanism.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
> 3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
>
> Diff: https://reviews.apache.org/r/45083/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Posted by haosdent huang <ha...@gmail.com>.
> On April 8, 2016, 6:41 a.m., Shuai Lin wrote:
> > 3rdparty/libprocess/include/process/collect.hpp, line 217
> > <https://reviews.apache.org/r/45083/diff/8/?file=1329609#file1329609line217>
> >
> > Got a compile error here:
> >
> >
> > ```
> > In file included from ../../../3rdparty/libprocess/src/metrics/metrics.cpp:19:
> > ../../../3rdparty/libprocess/include/process/collect.hpp:216:24: error: redefinition of default argument
> > const CollectMode& mode = CollectMode::ALL)
> > ^ ~~~~~~~~~~~~~~~~
> > ../../../3rdparty/libprocess/include/process/collect.hpp:51:24: note: previous definition is here
> > const CollectMode& mode = CollectMode::ALL);
> > ```
> >
> > After remvoe the default argument value in line 216 it compiles ok.
>
> Shuai Lin wrote:
> On ubuntu with g++ it works fine, but fails on osx with clang.
Thanks a lot! sorry about did't test in clang. Let me fix this.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/#review127744
-----------------------------------------------------------
On April 7, 2016, 10:36 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45083/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 10:36 a.m.)
>
>
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-5038
> https://issues.apache.org/jira/browse/MESOS-5038
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ANY mode to futures collect mechanism.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
> 3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
>
> Diff: https://reviews.apache.org/r/45083/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Posted by Shuai Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/#review127744
-----------------------------------------------------------
3rdparty/libprocess/include/process/collect.hpp (line 216)
<https://reviews.apache.org/r/45083/#comment191130>
Got a compile error here:
```
In file included from ../../../3rdparty/libprocess/src/metrics/metrics.cpp:19:
../../../3rdparty/libprocess/include/process/collect.hpp:216:24: error: redefinition of default argument
const CollectMode& mode = CollectMode::ALL)
^ ~~~~~~~~~~~~~~~~
../../../3rdparty/libprocess/include/process/collect.hpp:51:24: note: previous definition is here
const CollectMode& mode = CollectMode::ALL);
```
After remvoe the default argument value in line 216 it compiles ok.
- Shuai Lin
On April 7, 2016, 10:36 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45083/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 10:36 a.m.)
>
>
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-5038
> https://issues.apache.org/jira/browse/MESOS-5038
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added ANY mode to futures collect mechanism.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
> 3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
>
> Diff: https://reviews.apache.org/r/45083/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 45083: Added ANY mode to futures collect mechanism.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
-----------------------------------------------------------
(Updated April 7, 2016, 10:36 a.m.)
Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
Changes
-------
Added ANY mode to futures collect mechanism.
Summary (updated)
-----------------
Added ANY mode to futures collect mechanism.
Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038
Repository: mesos
Description (updated)
-------
Added ANY mode to futures collect mechanism.
Diffs (updated)
-----
3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
Diff: https://reviews.apache.org/r/45083/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 45083: Added a any mechanism for futures.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45083/
-----------------------------------------------------------
(Updated April 4, 2016, 5:12 p.m.)
Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
Changes
-------
Rebase and update reviewers.
Bugs: MESOS-5038
https://issues.apache.org/jira/browse/MESOS-5038
Repository: mesos
Description
-------
Added a any mechanism for futures.
Diffs (updated)
-----
3rdparty/libprocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc
3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401
Diff: https://reviews.apache.org/r/45083/diff/
Testing
-------
Thanks,
haosdent huang