[jira] [Commented] (DRILL-6347) Inconsistent method name "field".

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446958#comment-16446958 ] 

ASF GitHub Bot commented on DRILL-6347:
---------------------------------------

GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/drill/pull/1236

    DRILL-6347: Inconsistent method name "field".

    The method is names as "field", but the method is mainly doing appending. So that, rename the method as "append" should be better.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/drill field

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1236
    
----
commit ecef20386237eb154555ec76e8cf4eabac022c38
Author: Kui LIU <br...@...>
Date:   2018-04-21T20:03:56Z

    Change the method name 'field' to 'append'.

----


> Inconsistent method name "field".
> ---------------------------------
>
>                 Key: DRILL-6347
>                 URL: https://issues.apache.org/jira/browse/DRILL-6347
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is names as "field", but the method is mainly doing appending. So that, rename the method as "append" should be better.
> {code:java}
>  private void field(String label, String value) {
>       indent();
>       out.append(label)
>          .append(" = ")
>          .append(value)
>          .append("\n");
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)