You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/08/13 23:00:44 UTC
Review Request 68335: Added a CNI test to verify destroy while
preparing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/
-----------------------------------------------------------
Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
Bugs: MESOS-9142
https://issues.apache.org/jira/browse/MESOS-9142
Repository: mesos
Description
-------
This test is used to catch the regression described in MESOS-9142.
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b
Diff: https://reviews.apache.org/r/68335/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 68335: Added a CNI test to verify destroy while
preparing.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207240
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68333, 68334, 68335]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 13, 2018, 11 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 11 p.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test is used to catch the regression described in MESOS-9142.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
> src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b
>
>
> Diff: https://reviews.apache.org/r/68335/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68335: Added a CNI test to verify destroy while
preparing.
Posted by Deepak Goel <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207196
-----------------------------------------------------------
Ship it!
Ship It!
- Deepak Goel
On Aug. 13, 2018, 11 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 11 p.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test is used to catch the regression described in MESOS-9142.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
> src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b
>
>
> Diff: https://reviews.apache.org/r/68335/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68335: Added a CNI test to verify destroy while
preparing.
Posted by Sergey Urbanovich <se...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207187
-----------------------------------------------------------
Ship it!
LGTM
- Sergey Urbanovich
On Aug. 13, 2018, 11 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 11 p.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test is used to catch the regression described in MESOS-9142.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
> src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b
>
>
> Diff: https://reviews.apache.org/r/68335/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68335: Added a CNI test to verify destroy while
preparing.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207203
-----------------------------------------------------------
PASS: Mesos patch 68335 was successfully built and tested.
Reviews applied: `['68333', '68334', '68335']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2142/mesos-review-68335
- Mesos Reviewbot Windows
On Aug. 13, 2018, 11 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 11 p.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test is used to catch the regression described in MESOS-9142.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
> src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b
>
>
> Diff: https://reviews.apache.org/r/68335/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68335: Added a CNI test to verify destroy while
preparing.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207256
-----------------------------------------------------------
PASS: Mesos patch 68335 was successfully built and tested.
Reviews applied: `['68333', '68334', '68335']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2151/mesos-review-68335
- Mesos Reviewbot Windows
On Aug. 14, 2018, 12:05 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 12:05 p.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test is used to catch the regression described in MESOS-9142.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 419c94d601cd588c893a5324c4aef71c40ec0f61
>
>
> Diff: https://reviews.apache.org/r/68335/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68335: Added a CNI test to verify destroy while
preparing.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/
-----------------------------------------------------------
(Updated Aug. 14, 2018, 7:05 p.m.)
Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
Changes
-------
Addressed comments.
Bugs: MESOS-9142
https://issues.apache.org/jira/browse/MESOS-9142
Repository: mesos
Description
-------
This test is used to catch the regression described in MESOS-9142.
Diffs (updated)
-----
src/tests/containerizer/cni_isolator_tests.cpp 419c94d601cd588c893a5324c4aef71c40ec0f61
Diff: https://reviews.apache.org/r/68335/diff/2/
Changes: https://reviews.apache.org/r/68335/diff/1-2/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 68335: Added a CNI test to verify destroy while
preparing.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207220
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp
Lines 196-201 (patched)
<https://reviews.apache.org/r/68335/#comment290515>
Instead of making this internal method public, can we do something similar with `MesosContainerizerDestroyTest.DestroyWhilePreparing` which simulates the case of a destroy while isolator preparing is in progress too?
src/tests/containerizer/cni_isolator_tests.cpp
Lines 48-49 (patched)
<https://reviews.apache.org/r/68335/#comment290510>
A newline between.
- Qian Zhang
On Aug. 14, 2018, 7 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 7 a.m.)
>
>
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
>
>
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test is used to catch the regression described in MESOS-9142.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
> src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b
>
>
> Diff: https://reviews.apache.org/r/68335/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>