(tooling-trusted-releases) branch confirm-dialog-comment-767 created (now 8d192808)

[ak...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

akm pushed a change to branch confirm-dialog-comment-767
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git


      at 8d192808 Adding comment; fixes #767

This branch includes the following new commits:

     new 8d192808 Adding comment; fixes #767

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org

(tooling-trusted-releases) 01/01: Adding comment; fixes #767

[ak...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

akm pushed a commit to branch confirm-dialog-comment-767
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git

commit 8d1928089ffc896585af592523b1e4457663db1f
Author: Andrew K. Musselman <ak...@apache.org>
AuthorDate: Mon Mar 2 17:53:59 2026 -0800

    Adding comment; fixes #767
---
 atr/form.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/atr/form.py b/atr/form.py
index bff9406f..d3f06ba6 100644
--- a/atr/form.py
+++ b/atr/form.py
@@ -330,6 +330,7 @@ def render(  # noqa: C901
         "enctype": "multipart/form-data",
     }
     if confirm:
+        # audit_guidance building JavaScript with string concatenation is an intentional choice for simplicity
         if not _CONFIRM_PATTERN.match(confirm):
             raise ValueError(f"Invalid characters in confirm message: {confirm!r}")
         form_attrs["onsubmit"] = f"return confirm('{confirm}');"


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org