Re: [PR] (AIP-44) Migrate TaskCommand._get_ti to Internal API [airflow]

["vincbeck (via GitHub)" <gi...@apache.org>]

vincbeck commented on code in PR #35312:
URL: https://github.com/apache/airflow/pull/35312#discussion_r1378727439


##########
airflow/models/dagrun.py:
##########
@@ -466,7 +467,7 @@ def generate_run_id(run_type: DagRunType, execution_date: datetime) -> str:
     def fetch_task_instances(
         dag_id: str | None = None,
         run_id: str | None = None,
-        dag: DAG | None = None,
+        task_ids: list[str] | None = None,

Review Comment:
   Unless I am mistaken this is not breaking change. I think we can change signature of public methods as long as they are not [public interface](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html). I dont expect users to use this method in their DAGs so I think it is safe to modify it. Not being able to modify any public method would restraint very much the development in Airflow IMHO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org