[GitHub] flink pull request #3880: [FLINK-6457] Clean up ScalarFunction and TableFunc...

[Xpray <gi...@git.apache.org>]

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/3880

    [FLINK-6457] Clean up ScalarFunction and TableFunction interface

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-6457

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3880.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3880
    
----
commit c55d582227820110f7967ff8b39625deb2530f4d
Author: Xpray <le...@gmail.com>
Date:   2017-05-11T15:59:39Z

    [FLINK-6457] Clean up ScalarFunction and TableFunction interface

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3880: [FLINK-6457] Clean up ScalarFunction and TableFunction in...

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3880
  
    Hi @Xpray, I left a comment on the related JIRA issue. In short, I do not why we should remove methods with constant signature and call them via reflection. This makes the code more prone for failures, it is less comfortable for users that need to override the methods and does not change anything for users that do not need these methods.
    
    It would be great if you could reply on the JIRA.
    
    Thank you, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---