You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2015/06/09 17:49:28 UTC
Re: Review Request 33778: Adds RPM specfile and support scripting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review87208
-----------------------------------------------------------
Patch looks good. Would like to see this move from top level /packaging to build-support/packaging and have docs/packaging.md or build-support/packaging/README.md added with some details for anyone that may not be familiar with dependencies needed to create the packages. With these updates will happily commit this patch, nice work
(ultimately would like to see a gradle task for deb/rpm and maybe docker containers used to create the packages, but that is independant of this patch.)
- Jake Farrell
On May 19, 2015, 4:19 p.m., Steve Salevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 4:19 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-1116
> https://issues.apache.org/jira/browse/AURORA-1116
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries:
>
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
>
> If you'd like to give it a whirl, the following Make targets will spin up new RPMs:
>
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
>
> Let me know what you think, and thanks!
>
>
> Diffs
> -----
>
> packaging/rpm/Makefile PRE-CREATION
> packaging/rpm/aurora.init.sh PRE-CREATION
> packaging/rpm/aurora.logrotate PRE-CREATION
> packaging/rpm/aurora.service PRE-CREATION
> packaging/rpm/aurora.spec PRE-CREATION
> packaging/rpm/aurora.startup.sh PRE-CREATION
> packaging/rpm/aurora.sysconfig PRE-CREATION
> packaging/rpm/clusters.json PRE-CREATION
> packaging/rpm/thermos-observer.init.sh PRE-CREATION
> packaging/rpm/thermos-observer.logrotate PRE-CREATION
> packaging/rpm/thermos-observer.service PRE-CREATION
> packaging/rpm/thermos-observer.startup.sh PRE-CREATION
> packaging/rpm/thermos-observer.sysconfig PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33778/diff/
>
>
> Testing
> -------
>
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19
>
>
> Thanks,
>
> Steve Salevan
>
>
Re: Review Request 33778: Adds RPM specfile and support scripting
Posted by Steve Salevan <st...@gmail.com>.
> On June 9, 2015, 3:49 p.m., Jake Farrell wrote:
> > Patch looks good. Would like to see this move from top level /packaging to build-support/packaging and have docs/packaging.md or build-support/packaging/README.md added with some details for anyone that may not be familiar with dependencies needed to create the packages. With these updates will happily commit this patch, nice work
> >
> > (ultimately would like to see a gradle task for deb/rpm and maybe docker containers used to create the packages, but that is independant of this patch.)
Added documentation and adjusted toplevel directory.
- Steve
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33778/#review87208
-----------------------------------------------------------
On May 19, 2015, 4:19 p.m., Steve Salevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33778/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 4:19 p.m.)
>
>
> Review request for Aurora, Jake Farrell, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-1116
> https://issues.apache.org/jira/browse/AURORA-1116
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This review board adds support for building Red Hat-flavored packages for the Aurora scheduler alongside its client and Thermos-related binaries:
>
> aurora - Aurora Scheduler
> aurora-client - Aurora client and admin tool
> aurora-thermos - Thermos executor, runner, and observer
> aurora-debuginfo - Debugging symbols for Python/libmesos integration
>
> If you'd like to give it a whirl, the following Make targets will spin up new RPMs:
>
> make (nightly_srpm|nightly_rpm) - builds an RPM or SRPM with timestamped versioning, suitable for producing nightly updates
> make (release_srpm|release_rpm) - builds without timestamped versioning
>
> Let me know what you think, and thanks!
>
>
> Diffs
> -----
>
> packaging/rpm/Makefile PRE-CREATION
> packaging/rpm/aurora.init.sh PRE-CREATION
> packaging/rpm/aurora.logrotate PRE-CREATION
> packaging/rpm/aurora.service PRE-CREATION
> packaging/rpm/aurora.spec PRE-CREATION
> packaging/rpm/aurora.startup.sh PRE-CREATION
> packaging/rpm/aurora.sysconfig PRE-CREATION
> packaging/rpm/clusters.json PRE-CREATION
> packaging/rpm/thermos-observer.init.sh PRE-CREATION
> packaging/rpm/thermos-observer.logrotate PRE-CREATION
> packaging/rpm/thermos-observer.service PRE-CREATION
> packaging/rpm/thermos-observer.startup.sh PRE-CREATION
> packaging/rpm/thermos-observer.sysconfig PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33778/diff/
>
>
> Testing
> -------
>
> Successfully executed builds on EL 6/7 and F19/20, tested deployment on EL6 and F19
>
>
> Thanks,
>
> Steve Salevan
>
>