You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2016/08/02 08:21:23 UTC

[GitHub] cloudstack pull request #1621: Fix a little issue from PR1610 if the db.prop...

GitHub user milamberspace opened a pull request:

    https://github.com/apache/cloudstack/pull/1621

    Fix a little issue from PR1610 if the db.properties file hasn't EOL c\u2026

    \u2026haracter at the end of file
    
    And some improvements about the dir/file using variables
    
    cc @wido @rhtyd 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/milamberspace/cloudstack FixPR1610_addLineReturn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1621
    
----
commit bef40a8cee7df8e336cf7dd468cbe5edeb13aa33
Author: Milamber <mi...@apache.org>
Date:   2016-08-02T08:00:21Z

    Fix a little issue from PR1610 if the db.properties file hasn't EOL character at the end of file
    And some improvements about the dir/file using variables

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: Fix a little issue from PR1610 if the db.properties ...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    We dont need a PR for master. It will be forward merged. 
    If you can create a jira ticket for this (even better would be to reuse the one used in PR1610), it will be useful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    Thanks @milamberspace for the PR, I'll merge it now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    @jburwell the cause of failure is due to an env issue (`java.lang.OutOfMemoryError: PermGen space issue`), @milamberspace can you close and open the PR, or do a push -f to force Travis to run again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: Fix a little issue from PR1610 if the db.properties ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    LGTM thanks @milamberspace 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian repo: http://packages.shapeblue.com/cloudstack/pr/1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    @borisstoyanov do you have the bandwidth to manually test upgrading 4.8 to 4.9 using this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    The changes won't be tested by Trillian as it does not support upgrade tests yet. Based on the packaging result, we can accept it if anyone has performed an upgrade test manually. /cc @karuturi @jburwell 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: Fix a little issue from PR1610 if the db.properties ...

Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    Jira ticket done.
    CLOUDSTACK-6671


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    Trillian test result (trillian-pr1621-31-vmware-55u3-cs49): 
    Test completed. 40 look ok, 12 have errors
    Test | Result | Time
    --- | --- | ---
    test_DeployVmAntiAffinityGroup_in_project | Success | 373.303
    test_create_pvlan_network | Success | 5.252
    test_DeployVmAntiAffinityGroup | Success | 368.077
    test_dedicatePublicIpRange | `marvin.cloudstackException.CloudstackAPIException` | 0.258
    test_deploy_vgpu_enabled_vm | Skipped | 0.006
    test_deploy_vm_from_iso | Success | 814.038
    test_01_scale_vm | Skipped | 66.518
    test_00_deploy_vm_root_resize | Success | 6.467
    test_01_deploy_vm_root_resize | Success | 6.245
    test_02_deploy_vm_root_resize | Success | 6.257
    test_01_router_internal_basic | Success | 0.524
    test_02_router_internal_adv | Success | 0.996
    test_03_restart_network_cleanup | Success | 166.062
    test_04_restart_network_wo_cleanup | Success | 5.657
    test_05_router_basic | Success | 0.027
    test_06_router_advanced | Success | 0.045
    test_07_stop_router | Success | 20.208
    test_08_start_router | Success | 125.800
    test_09_reboot_router | Success | 155.991
    test_deployvm_firstfit | Success | 256.851
    test_deployvm_userconcentrated | Success | 111.206
    test_deployvm_userdispersing | Success | 60.731
    test_deployvm_userdata | Success | 176.604
    test_deployvm_userdata_post | Success | 25.461
    test_01_sys_vm_start | Success | 0.125
    test_02_sys_template_ready | Success | 0.100
    test_01_create_disk_offering | Success | 0.095
    test_02_create_sparse_type_disk_offering | Success | 0.091
    test_04_create_fat_type_disk_offering | Success | 0.073
    test_02_edit_disk_offering | Success | 0.043
    test_03_delete_disk_offering | Success | 0.031
    test_default_role_deletion | Success | 6.420
    test_role_account_acls | Success | 7.948
    test_role_account_acls_multiple_mgmt_servers | Success | 7.787
    test_role_inuse_deletion | Success | 6.283
    test_role_lifecycle_create | Success | 6.316
    test_role_lifecycle_delete | Success | 12.140
    test_role_lifecycle_list | Success | 6.311
    test_role_lifecycle_update | Success | 11.458
    test_role_lifecycle_update_role_inuse | Success | 6.324
    test_rolepermission_lifecycle_concurrent_updates | Success | 6.490
    test_rolepermission_lifecycle_create | Success | 6.278
    test_rolepermission_lifecycle_delete | Success | 6.240
    test_rolepermission_lifecycle_list | Success | 6.452
    test_rolepermission_lifecycle_update | Success | 6.586
    test_01_create_service_offering | Success | 0.107
    test_02_edit_service_offering | Success | 0.072
    test_03_delete_service_offering | Success | 0.033
    test_04_change_offering_small | Success | 97.643
    test_UpdateConfigParamWithScope | Success | 0.136
    ContextSuite context=TestDedicateGuestVlanRange>:setup | `exceptions.AttributeError` | 0.000
    test_01_snapshot_root_disk | Success | 202.120
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 441.611
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 702.684
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `exceptions.TypeError` | 436.238
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `exceptions.TypeError` | 551.995
    test_01_list_sec_storage_vm | Success | 0.097
    test_02_list_cpvm_vm | Success | 0.115
    test_03_ssvm_internals | Success | 4.202
    test_04_cpvm_internals | Success | 1.357
    test_05_stop_ssvm | Success | 214.221
    test_06_stop_cpvm | Success | 237.023
    test_07_reboot_ssvm | Success | 159.024
    test_08_reboot_cpvm | Success | 156.759
    test_09_destroy_ssvm | Success | 264.121
    test_10_destroy_cpvm | Success | 267.044
    test_01_create_iso | Success | 66.439
    test_02_edit_iso | Success | 0.080
    test_03_delete_iso | Success | 95.202
    test_04_extract_Iso | Success | 5.165
    test_05_iso_permissions | Success | 0.045
    test_06_copy_iso | Skipped | 0.000
    test_07_list_default_iso | Success | 0.038
    test_01_list_volumes | Success | 0.023
    test_02_list_templates | Success | 0.032
    test_03_list_snapshots | Success | 0.067
    test_static_role_account_acls | Skipped | 0.020
    test_01_create_lb_rule_src_nat | Success | 208.747
    test_02_create_lb_rule_non_nat | Success | 207.669
    test_assign_and_removal_lb | Success | 149.310
    login_test_saml_user | Success | 21.728
    test_01_create_template | Success | 226.419
    test_CreateTemplateWithDuplicateName | Success | 357.211
    test_02_edit_template | Success | 90.203
    test_03_delete_template | Success | 5.094
    test_04_extract_template | Success | 55.705
    test_05_template_permissions | Success | 0.039
    test_06_copy_template | Skipped | 0.000
    test_07_list_public_templates | Success | 0.023
    test_08_list_system_templates | Success | 0.018
    test_nic_secondaryip_add_remove | Success | 293.483
    test_network_acl | Success | 262.254
    test_delete_account | Success | 368.744
    test_01_port_fwd_on_src_nat | Success | 111.893
    test_02_port_fwd_on_non_src_nat | Success | 55.702
    test_public_ip_admin_account | Success | 40.301
    test_public_ip_user_account | Success | 10.258
    test_reboot_router | Success | 624.975
    test_releaseIP | Success | 344.235
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 125.447
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.666
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 76.771
    test_vm_nic_adapter_vmxnet3 | Skipped | 0.000
    test_advZoneVirtualRouter | Success | 0.019
    test_deploy_vm | Success | 0.021
    test_deploy_vm_multiple | Success | 233.029
    test_01_stop_vm | Success | 5.104
    test_02_start_vm | Success | 20.215
    test_03_reboot_vm | Success | 5.126
    test_06_destroy_vm | Success | 10.151
    test_07_restore_vm | Success | 0.102
    test_08_migrate_vm | Success | 86.138
    test_09_expunge_vm | Success | 125.232
    test_10_attachAndDetach_iso | Success | 71.933
    test_01_nic | Success | 732.163
    test_extendPhysicalNetworkVlan | `exceptions.AttributeError` | 0.031
    test_01_test_vm_volume_snapshot | `marvin.cloudstackException.CloudstackAPIException` | 171.347
    test_01_create_vm_snapshots | Success | 161.789
    test_02_revert_vm_snapshots | Success | 227.375
    test_03_delete_vm_snapshots | Success | 275.274
    test_oobm_background_powerstate_sync | Success | 15.683
    test_oobm_configure_default_driver | Success | 0.097
    test_oobm_configure_invalid_driver | Success | 0.107
    test_oobm_disable_feature_invalid | Success | 0.243
    test_oobm_disable_feature_valid | Success | 0.189
    test_oobm_enable_feature_invalid | Success | 0.097
    test_oobm_enable_feature_valid | Success | 5.166
    test_oobm_enabledisable_across_clusterzones | Success | 49.339
    test_oobm_issue_power_cycle | Success | 15.752
    test_oobm_issue_power_off | Success | 10.553
    test_oobm_issue_power_on | Success | 15.559
    test_oobm_issue_power_reset | Success | 10.546
    test_oobm_issue_power_soft | Success | 15.567
    test_oobm_issue_power_status | Success | 10.553
    test_oobm_multiple_mgmt_server_ownership | Success | 16.584
    test_oobm_zchange_password | Success | 20.582
    test_UpdateStorageOverProvisioningFactor | Success | 0.159
    test_01_create_volume | Success | 519.147
    test_02_attach_volume | Success | 58.848
    test_03_download_attached_volume | Success | 20.339
    test_04_delete_attached_volume | Success | 20.263
    test_05_detach_volume | Success | 105.300
    test_06_download_detached_volume | Success | 60.595
    test_07_resize_fail | Skipped | 10.297
    test_08_resize_volume | Skipped | 10.125
    test_09_delete_detached_volume | Success | 25.919
    test_isolate_network_password_server | `Failure` | 171.731
    test_createPortablePublicIPAcquire | Success | 15.555
    test_createPortablePublicIPRange | Success | 15.315
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 680.415
    test_02_redundant_VPC_default_routes | Success | 804.824
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 585.938
    test_04_rvpc_network_garbage_collector_nics | Success | 977.793
    test_05_rvpc_multi_tiers | Success | 807.630
    test_01_primary_storage_iscsi | Skipped | 0.028
    test_01_primary_storage_nfs | Success | 36.481
    test_01_vpc_privategw_acl | `Failure` | 152.219
    test_02_vpc_privategw_static_routes | `Failure` | 267.850
    test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 263.016
    test_04_rvpc_privategw_static_routes | `Failure` | 484.173
    test_01_VPC_nics_after_destroy | Success | 725.109
    test_02_VPC_default_routes | Success | 455.868
    test_createRegion | Success | 0.047
    test_01_reset_vm_on_reboot | Success | 95.728
    test_01_updatevolumedetail | Success | 5.111
    test_router_dhcphosts | `Failure` | 169.058
    ContextSuite context=TestRouterDHCPHosts>:teardown | `exceptions.Exception` | 189.308
    test_02_routervm_iptables_policies | `Failure` | 236.518
    test_01_single_VPC_iptables_policies | `Failure` | 457.407
    test_01_isolate_network_FW_PF_default_routes_egress_true | Success | 293.999
    test_02_isolate_network_FW_PF_default_routes_egress_false | Success | 303.771
    test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 476.805
    test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 505.377
    test_03_RVR_Network_check_router_state | Success | 371.011
    test_01_redundant_vpc_site2site_vpn | `exceptions.TypeError` | 869.206
    test_01_vpc_remote_access_vpn | `exceptions.UnboundLocalError` | 0.072
    test_01_vpc_site2site_vpn | `exceptions.TypeError` | 567.259
    Trillian env - trillian-pr1621-31-vmware-55u3-cs49, Job ID 31
    Marvin logs at: http://packages.shapeblue.com/cloudstack/pr/1621/trillian/trillian-pr1621-31-vmware-55u3-cs49


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1621: [CLOUDSTACK-9444] Fix a little issue from PR1...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    I would like to get this PR into 4.9.1.0.
    
    @borisstoyanov have you gotten a change to test this PR?
    
    @rhtyd @milamberspace could you investigate the cause of the Travis build failure?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    @rhtyd a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: Fix a little issue from PR1610 if the db.properties ...

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    LGTM!
    
    Thanks for the fix. Could you also open one for master? It needs to be fixed there as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    @jburwell I can do it late next week, pretty stacked up currently. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1621: [CLOUDSTACK-9444] Fix a little issue from PR1...

Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace closed the pull request at:

    https://github.com/apache/cloudstack/pull/1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1621: [CLOUDSTACK-9444] Fix a little issue from PR1...

Posted by milamberspace <gi...@git.apache.org>.
GitHub user milamberspace reopened a pull request:

    https://github.com/apache/cloudstack/pull/1621

    [CLOUDSTACK-9444] Fix a little issue from PR1610 if the db.properties file hasn't EOL c\u2026

    \u2026haracter at the end of file
    
    And some improvements about the dir/file using variables
    
    cc @wido @rhtyd 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/milamberspace/cloudstack FixPR1610_addLineReturn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1621
    
----
commit 6051fa503a2da7b96256f21e6b7c42aa1f3cb01e
Author: Milamber <mi...@apache.org>
Date:   2016-08-02T08:00:21Z

    Fix a little issue from PR1610 if the db.properties file hasn't EOL character at the end of file
    And some improvements about the dir/file using variables

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    Alright, your PR did not break packaging! Packages built and available at: http://packages.shapeblue.com/cloudstack/custom/github-1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    <i'>Holy monkeys!</i> <b>Failed</b> to build one or more CloudStack packages that would have been available at: http://packages.shapeblue.com/cloudstack/custom/github-1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1621
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---