[GitHub] [nuttx] btashton commented on pull request #8329: Ch32v: a pull request of commits to date

["btashton (via GitHub)" <gi...@apache.org>]

btashton commented on PR #8329:
URL: https://github.com/apache/nuttx/pull/8329#issuecomment-1407465722

   > Ack. Sorry. I need to figure out how to get these to go to MY repo and not
   > the public one. Git can be so frustrating to me. The commits and pushes go
   > to https://github.com/robertlipe/incubator-nuttx/tree/ch32v but the PRs go
   > to upstream while I'm clearly far from wanting to upstream it.
   > 
   > Apologies for the distraction, but I'll leave this PR open just for
   > mindshare in case anyone goes looking for a WCH port and wants to help.
   > 
   > I'll go ahead and fold in your comments because they're just good sense and
   > will need to be done anyway. Thanx for that.
   > 
   > RJL
   > 
   > On Sat, Jan 28, 2023 at 12:53 PM Alan Carvalho de Assis <
   > ***@***.***> wrote:
   > 
   > > @robertlipe <https://github.com/robertlipe> please squash/organize these
   > > commits, because these many reverts it is difficult to review. You don't
   > > need to close this PR, just use git rebase -i HEAD~N as explained here:
   > > https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request
   > >
   > > —
   > > Reply to this email directly, view it on GitHub
   > > <https://github.com/apache/nuttx/pull/8329#issuecomment-1407463021>, or
   > > unsubscribe
   > > <https://github.com/notifications/unsubscribe-auth/ACCSD3644UKDRKDEHXNBFI3WUVTLRANCNFSM6AAAAAAUJXM7FA>
   > > .
   > > You are receiving this because you were mentioned.Message ID:
   > > ***@***.***>
   > >
   > 
   
   The confusion is likely a GitHub thing vs a git thing.  By default when you push a new branch it provides a link to create a PR in the UI, but by default it will set it against the _upstream_ and not your fork. 
   
   If I want to work in my playground fist but want to have a "PR" to view I will update the target branch in that UI to be master on _my_ repo.  This does mean creating a new PR from my branch to upstream later (you don't need a new branch). 
   
   You can also choose to just not create the PR via the UI when you push and instead just use the diff view (although it will push you to create a PR...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org