You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2024/08/28 19:26:19 UTC
[I] Remove `InMemoryCatalog` from the test-codebase [iceberg-python]
Fokko opened a new issue, #1110:
URL: https://github.com/apache/iceberg-python/issues/1110
### Feature Request / Improvement
`InMemoryCatalog` can be replaced by the SqlCatalog with Sqlite as a backend. Less code is more :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Remove `InMemoryCatalog` from the test-codebase [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed issue #1110: Remove `InMemoryCatalog` from the test-codebase
URL: https://github.com/apache/iceberg-python/issues/1110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Remove `InMemoryCatalog` from the test-codebase [iceberg-python]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on issue #1110:
URL: https://github.com/apache/iceberg-python/issues/1110#issuecomment-2332795085
@Fokko I agree with @kevinjqliu on the alias proposition, I implemented https://github.com/apache/iceberg-python/pull/1140 which makes `InMemoryCatalog` a subclass of `SqlCatalog`, and overrides some methods to simplify the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Remove `InMemoryCatalog` from the test-codebase [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1110:
URL: https://github.com/apache/iceberg-python/issues/1110#issuecomment-2327513232
perhaps its a good idea to alias a new `InMemoryCatalog` implementation using SqlCatalog
such as
https://github.com/apache/iceberg-python/blob/9857107561d2267813b7ce150b01b4e6ac4b3e34/tests/catalog/test_sql.py#L113-L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org