You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Carsten Ziegeler (Jira)" <ji...@apache.org> on 2022/05/13 11:23:00 UTC

[jira] [Resolved] (SLING-11319) Remove getBaseDirectory from artifact deployer

     [ https://issues.apache.org/jira/browse/SLING-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-11319.
--------------------------------------
    Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/e04587cb7ee0acd17cfd1cd310979c729c8103ff

Removed that method from the interface and changed the deploy method to return a string

> Remove getBaseDirectory from artifact deployer
> ----------------------------------------------
>
>                 Key: SLING-11319
>                 URL: https://issues.apache.org/jira/browse/SLING-11319
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content-Package to Feature Model Converter
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.1.16
>
>
> The interface ArtifactDeployer has a method getBaseDirectory which seems out of place. It is breaking the abstraction. It seems the only place where it is used is for log output.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)