You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2022/08/30 01:20:50 UTC

[superset] 01/01: Revert "ok (#21116)"

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch revert-tab-name
in repository https://gitbox.apache.org/repos/asf/superset.git

commit cce3db0fdb38cbca2819cc9793b6dc4bbdea1916
Author: hughhhh <hu...@gmail.com>
AuthorDate: Mon Aug 29 18:20:00 2022 -0700

    Revert "ok (#21116)"
    
    This reverts commit 642a0d77042e9350d92e3f35e99cfd24937a23b9.
---
 superset/config.py                     | 1 -
 superset/templates/superset/basic.html | 1 -
 2 files changed, 2 deletions(-)

diff --git a/superset/config.py b/superset/config.py
index 647dc81ea7..ffc7528fa4 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -103,7 +103,6 @@ PACKAGE_JSON_FILE = pkg_resources.resource_filename(
 #     "rel": "icon"
 # },
 FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
-TAB_TITLE = None
 
 
 def _try_json_readversion(filepath: str) -> Optional[str]:
diff --git a/superset/templates/superset/basic.html b/superset/templates/superset/basic.html
index 03796ceb8c..fff57fdb9f 100644
--- a/superset/templates/superset/basic.html
+++ b/superset/templates/superset/basic.html
@@ -22,7 +22,6 @@
 {% from 'superset/partials/asset_bundle.html' import css_bundle, js_bundle with context %}
 
 {% set favicons = appbuilder.app.config['FAVICONS'] %}
-{% set title = appbuilder.app.config['TAB_TITLE'] %}
 <html>
   <head>
     <title>