[GitHub] spark pull request #16504: [SPARK-19126][Docs] Update Join Documentation Acr...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16504#discussion_r95091891
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -2313,9 +2313,9 @@ setMethod("dropDuplicates",
     #' @param joinExpr (Optional) The expression used to perform the join. joinExpr must be a
     #' Column expression. If joinExpr is omitted, the default, inner join is attempted and an error is
     #' thrown if it would be a Cartesian Product. For Cartesian join, use crossJoin instead.
    -#' @param joinType The type of join to perform. The following join types are available:
    -#' 'inner', 'outer', 'full', 'fullouter', leftouter', 'left_outer', 'left',
    -#' 'right_outer', 'rightouter', 'right', and 'leftsemi'. The default joinType is "inner".
    +#' @param joinType The type of join to perform, default 'inner'.
    +#' Must be any of: 'inner', 'cross', 'outer', 'full', 'full_outer',
    +#' 'left', 'left_outer', 'right', 'right_outer', 'left_semi', and 'left_anti'.
    --- End diff --
    
    this isn't really quite matching the code -
    we need to add `cross`, `full_outer`, `left_anti`, `left_semi` to L2347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org