[jira] [Comment Edited] (HBASE-10451) Enable back Tag compression on HFiles

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902964#comment-13902964 ] 

Anoop Sam John edited comment on HBASE-10451 at 2/17/14 5:16 AM:
-----------------------------------------------------------------

The test failure shows an issue in patch.. -1
{code}
+      if (current.decodedTagsCount != null) {
+        // remove entries which were just added to dictionary as part of decoding tags in current
+        // KV. current.decodedTagsCount's second item is the number of tags which were not in
+        // dictionary at the time of uncompress. These were newly added to dictionary as part of
+        // decode tags and so we have to remove now.
+        assert tagCompressionContext != null;
+        tagCompressionContext.removeFromDicionary(current.decodedTagsCount.getSecond());
+      }
{code}
But before this line we swap current and previous STATE. So what we have to check at this point is PREVIOUS state and based on which do the remove from dict.  

New patch with change.  

BTW failure in org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers seems not related!


was (Author: anoop.hbase):
The test failure shows an issue in patch.. -1
{code}
+      if (current.decodedTagsCount != null) {
+        // remove entries which were just added to dictionary as part of decoding tags in current
+        // KV. current.decodedTagsCount's second item is the number of tags which were not in
+        // dictionary at the time of uncompress. These were newly added to dictionary as part of
+        // decode tags and so we have to remove now.
+        assert tagCompressionContext != null;
+        tagCompressionContext.removeFromDicionary(current.decodedTagsCount.getSecond());
+      }
{code}
But before this line we swap current and previous STATE. So what we have to check at this point is PREVIOUS state and based on which do the remove from dict.  

New patch with change.  


> Enable back Tag compression on HFiles
> -------------------------------------
>
>                 Key: HBASE-10451
>                 URL: https://issues.apache.org/jira/browse/HBASE-10451
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 0.98.1, 0.99.0
>
>         Attachments: HBASE-10451.patch, HBASE-10451_V2.patch, HBASE-10451_V3.patch, HBASE-10451_V4.patch
>
>
> HBASE-10443 disables tag compression on HFiles. This Jira is to fix the issues we have found out in HBASE-10443 and enable it back.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)