You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/11 12:28:48 UTC
[GitHub] [dubbo-spi-extensions] wxbty opened a new pull request, #167: [Dubbo-SPECIFY-ADDRESS] fix npe when zk push url
wxbty opened a new pull request, #167:
URL: https://github.com/apache/dubbo-spi-extensions/pull/167
Signed-off-by: x-shadow-man <14...@qq.com>
## What is the purpose of the change
bugfix of issue #166
## Brief changelog
add npe judge, if null, reconstruct PathURLAddress obj
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
- [ x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
in the pull request should have a meaningful subject line and body.
- [x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
exist. If the new feature or significant change is committed, please remember to add sample
in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
unit-test and integration-test pass.
- [ x] If this contribution is large, please follow
the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] wxbty commented on pull request #167: [Dubbo-SPECIFY-ADDRESS] fix npe when zk push url
Posted by GitBox <gi...@apache.org>.
wxbty commented on PR #167:
URL: https://github.com/apache/dubbo-spi-extensions/pull/167#issuecomment-1317960084
The test found that there was a problem with the previous one. We need to exclude the type of InstanceAddressURL. It will throw an exception when getUrlAddress. Now the dynamic change of ip can work normally.
please look again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] codecov-commenter commented on pull request #167: [Dubbo-SPECIFY-ADDRESS] fix npe when zk push url
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #167:
URL: https://github.com/apache/dubbo-spi-extensions/pull/167#issuecomment-1312402384
# [Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#167](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f7bbaae) into [master](https://codecov.io/gh/apache/dubbo-spi-extensions/commit/b9a5f3004124622e0d160e614a67e9ccdb839750?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9a5f30) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #167 +/- ##
============================================
- Coverage 39.67% 39.39% -0.28%
+ Complexity 510 508 -2
============================================
Files 138 138
Lines 4492 4490 -2
Branches 553 553
============================================
- Hits 1782 1769 -13
- Misses 2516 2524 +8
- Partials 194 197 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ess/DefaultUserSpecifiedServiceAddressBuilder.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tY2x1c3Rlci1leHRlbnNpb25zL2R1YmJvLWNsdXN0ZXItc3BlY2lmeS1hZGRyZXNzLWR1YmJvMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3BlY2lmeWFkZHJlc3MvRGVmYXVsdFVzZXJTcGVjaWZpZWRTZXJ2aWNlQWRkcmVzc0J1aWxkZXIuamF2YQ==) | `86.20% <0.00%> (-13.80%)` | :arrow_down: |
| [...g/apache/dubbo/remoting/p2p/support/FileGroup.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcmVtb3RpbmctZXh0ZW5zaW9ucy9kdWJiby1yZW1vdGluZy1wMnAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3AycC9zdXBwb3J0L0ZpbGVHcm91cC5qYXZh) | `41.50% <0.00%> (-9.44%)` | :arrow_down: |
| [...g/p2p/exchange/support/MulticastExchangeGroup.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcmVtb3RpbmctZXh0ZW5zaW9ucy9kdWJiby1yZW1vdGluZy1wMnAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3AycC9leGNoYW5nZS9zdXBwb3J0L011bHRpY2FzdEV4Y2hhbmdlR3JvdXAuamF2YQ==) | `77.50% <0.00%> (-5.00%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcmVtb3RpbmctZXh0ZW5zaW9ucy9kdWJiby1yZW1vdGluZy1taW5hL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbWluYS9NaW5hQ2xpZW50LmphdmE=) | `56.92% <0.00%> (-1.54%)` | :arrow_down: |
| [...org/apache/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcmVnaXN0cnktZXh0ZW5zaW9ucy9kdWJiby1yZWdpc3RyeS1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVnaXN0cnkvcmVkaXMvUmVkaXNSZWdpc3RyeS5qYXZh) | `53.18% <0.00%> (-1.50%)` | :arrow_down: |
| [...ata/SeataTransactionPropagationProviderFilter.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tZmlsdGVyLWV4dGVuc2lvbnMvZHViYm8tZmlsdGVyLXNlYXRhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9zZWF0YS9TZWF0YVRyYW5zYWN0aW9uUHJvcGFnYXRpb25Qcm92aWRlckZpbHRlci5qYXZh) | `76.47% <0.00%> (-0.68%)` | :arrow_down: |
| [...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcmVnaXN0cnktZXh0ZW5zaW9ucy9kdWJiby1yZWdpc3RyeS1ldGNkMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVnaXN0cnkvZXRjZC9FdGNkUmVnaXN0cnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ache/dubbo/registry/etcd/EtcdServiceDiscovery.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcmVnaXN0cnktZXh0ZW5zaW9ucy9kdWJiby1yZWdpc3RyeS1ldGNkMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVnaXN0cnkvZXRjZC9FdGNkU2VydmljZURpc2NvdmVyeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/167/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcmVtb3RpbmctZXh0ZW5zaW9ucy9kdWJiby1yZW1vdGluZy1ldGNkMy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvZXRjZC9qZXRjZC9KRXRjZENsaWVudFdyYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] AlbumenJ merged pull request #167: [Dubbo-SPECIFY-ADDRESS] fix npe when zk push url
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged PR #167:
URL: https://github.com/apache/dubbo-spi-extensions/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org