You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/02/23 12:42:40 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #24325: Fix `hint` sharding strategy in DistSQL
Qianyi951015 opened a new pull request, #24325:
URL: https://github.com/apache/shardingsphere/pull/24325
related to #23823.
Changes proposed in this pull request:
- Fix `hint` sharding strategy in DistSQL
- Fix `hint` sharding strategy for `ConvertYamlConfigurationExecutor`
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24325: Fix `hint` sharding strategy in DistSQL
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24325:
URL: https://github.com/apache/shardingsphere/pull/24325#issuecomment-1441774872
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24325](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (45f189e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d095c58d967ca75acdefa41c17e849aa1f0137f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d095c58) will **increase** coverage by `0.01%`.
> The diff coverage is `30.76%`.
> :exclamation: Current head 45f189e differs from pull request most recent head 3427b07. Consider uploading reports for the commit 3427b07 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24325 +/- ##
============================================
+ Coverage 49.95% 49.97% +0.01%
- Complexity 1579 1582 +3
============================================
Files 3252 3253 +1
Lines 53472 53487 +15
Branches 9864 9868 +4
============================================
+ Hits 26714 26732 +18
+ Misses 24387 24384 -3
Partials 2371 2371
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/parser/core/ShardingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvU2hhcmRpbmdEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../authentication/OpenGaussAuthenticationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvdHlwZS9vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL29wZW5nYXVzcy9hdXRoZW50aWNhdGlvbi9PcGVuR2F1c3NBdXRoZW50aWNhdGlvbkVuZ2luZS5qYXZh) | `28.00% <0.00%> (-5.34%)` | :arrow_down: |
| [...al/queryable/ConvertYamlConfigurationExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2hhbmRsZXIvZGlzdHNxbC9yYWwvcXVlcnlhYmxlL0NvbnZlcnRZYW1sQ29uZmlndXJhdGlvbkV4ZWN1dG9yLmphdmE=) | `79.32% <100.00%> (+0.51%)` | :arrow_up: |
| [...tion/authenticator/OpenGaussAuthenticatorType.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvdHlwZS9vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL29wZW5nYXVzcy9hdXRoZW50aWNhdGlvbi9hdXRoZW50aWNhdG9yL09wZW5HYXVzc0F1dGhlbnRpY2F0b3JUeXBlLmphdmE=) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [...icator/impl/OpenGaussMD5PasswordAuthenticator.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvdHlwZS9vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL29wZW5nYXVzcy9hdXRoZW50aWNhdGlvbi9hdXRoZW50aWNhdG9yL2ltcGwvT3BlbkdhdXNzTUQ1UGFzc3dvcmRBdXRoZW50aWNhdG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...mpl/OpenGaussSCRAMSha256PasswordAuthenticator.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvdHlwZS9vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL29wZW5nYXVzcy9hdXRoZW50aWNhdGlvbi9hdXRoZW50aWNhdG9yL2ltcGwvT3BlbkdhdXNzU0NSQU1TaGEyNTZQYXNzd29yZEF1dGhlbnRpY2F0b3IuamF2YQ==) | `22.22% <100.00%> (+22.22%)` | :arrow_up: |
| [...cator/impl/PostgreSQLMD5PasswordAuthenticator.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvdHlwZS9wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9mcm9udGVuZC9wb3N0Z3Jlc3FsL2F1dGhlbnRpY2F0aW9uL2F1dGhlbnRpY2F0b3IvaW1wbC9Qb3N0Z3JlU1FMTUQ1UGFzc3dvcmRBdXRoZW50aWNhdG9yLmphdmE=) | `100.00% <0.00%> (+9.09%)` | :arrow_up: |
| [...nticator/impl/MySQLClearPasswordAuthenticator.java](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvdHlwZS9teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvbXlzcWwvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRvci9pbXBsL015U1FMQ2xlYXJQYXNzd29yZEF1dGhlbnRpY2F0b3IuamF2YQ==) | `83.33% <0.00%> (+16.66%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/shardingsphere/pull/24325?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24325: Fix `hint` sharding strategy in DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24325:
URL: https://github.com/apache/shardingsphere/pull/24325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24325: Fix `hint` sharding strategy in DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #24325:
URL: https://github.com/apache/shardingsphere/pull/24325#discussion_r1115684309
##########
proxy/backend/core/src/test/resources/conf/convert/config-sharding.yaml:
##########
@@ -93,6 +96,10 @@ rules:
props:
algorithm-expression: t_order_item_${order_id % 2}
datetime-lower: "2022-01-01 00:00:00"
+ t_order_item_hint_inline:
+ type: HINT_INLINE
+ props:
+ algorithm-expression: t_order_item_${order_id % 2}
Review Comment:
Property name in `HINT_INLINE` should be `value`, there is no column name in the strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Qianyi951015 commented on a diff in pull request #24325: Fix `hint` sharding strategy in DistSQL
Posted by "Qianyi951015 (via GitHub)" <gi...@apache.org>.
Qianyi951015 commented on code in PR #24325:
URL: https://github.com/apache/shardingsphere/pull/24325#discussion_r1115708406
##########
proxy/backend/core/src/test/resources/conf/convert/config-sharding.yaml:
##########
@@ -93,6 +96,10 @@ rules:
props:
algorithm-expression: t_order_item_${order_id % 2}
datetime-lower: "2022-01-01 00:00:00"
+ t_order_item_hint_inline:
+ type: HINT_INLINE
+ props:
+ algorithm-expression: t_order_item_${order_id % 2}
Review Comment:
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24325: Fix `hint` sharding strategy in DistSQL
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #24325:
URL: https://github.com/apache/shardingsphere/pull/24325#discussion_r1115684999
##########
proxy/backend/core/src/test/resources/conf/convert/config-sharding.yaml:
##########
@@ -93,6 +96,10 @@ rules:
props:
algorithm-expression: t_order_item_${order_id % 2}
datetime-lower: "2022-01-01 00:00:00"
+ t_order_item_hint_inline:
+ type: HINT_INLINE
+ props:
+ algorithm-expression: t_order_item_${order_id % 2}
Review Comment:
FYI: "t_order_$->{value % 4}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org