You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/06/22 21:05:04 UTC

[GitHub] couchdb-fauxton pull request: Move the click handler to the header

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/469

    Move the click handler to the header

    The toggle event was placed one node too high on the Index
    section in the sidebar, which resulted in the section being
    expanded/contracted when a subelement is clicked, rather than
    just the parent.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton sidebar-event-tweak

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #469
    
----
commit 42838ab584aa1dfb0c0aa08d8aed8bef92641b8d
Author: Ben Keen <be...@gmail.com>
Date:   2015-06-22T19:03:42Z

    Move the click handler to the header
    
    The toggle event was placed one node too high on the Index
    section in the sidebar, which resulted in the section being
    expanded/contracted when a subelement is clicked, rather than
    just the parent.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Move sidebar click handler to sectio...

Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/469#issuecomment-114226156
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Move sidebar click handler to sectio...

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/469#issuecomment-114340658
  
    Thanks Michelle. Merged as 52753f1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Move sidebar click handler to sectio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/469


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---