You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mv...@apache.org on 2017/05/24 07:54:28 UTC
lucene-solr:branch_6_6: LUCENE-7810: Fix numeric join equals test
failure.
Repository: lucene-solr
Updated Branches:
refs/heads/branch_6_6 f237b8db5 -> 87107084c
LUCENE-7810: Fix numeric join equals test failure.
Numeric join equals isn't based on the index reader, but rather on the collected join values.
In a test failure during the second indexing round no new join values were indexed causing the equals assertion to fail.
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/87107084
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/87107084
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/87107084
Branch: refs/heads/branch_6_6
Commit: 87107084c3a90f7ef253c00423b12cc1790f8c2f
Parents: f237b8d
Author: Martijn van Groningen <ma...@gmail.com>
Authored: Wed May 24 09:50:23 2017 +0200
Committer: Martijn van Groningen <mv...@apache.org>
Committed: Wed May 24 09:53:39 2017 +0200
----------------------------------------------------------------------
.../src/test/org/apache/lucene/search/join/TestJoinUtil.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/87107084/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
----------------------------------------------------------------------
diff --git a/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java b/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
index e089cd5..c4953b2 100644
--- a/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
+++ b/lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
@@ -1153,7 +1153,7 @@ public class TestJoinUtil extends LuceneTestCase {
indexSearcher, scoreMode1)));
}
- for (int i = 0; i < 13; i++) {
+ for (int i = 14; i < 26; i++) {
Document doc = new Document();
doc.add(new TextField("id", "new_id" , Field.Store.NO));
doc.add(new TextField("name", "name5", Field.Store.NO));
@@ -1171,7 +1171,7 @@ public class TestJoinUtil extends LuceneTestCase {
}
try (IndexReader r = w.getReader()) {
IndexSearcher indexSearcher = new IndexSearcher(r);
- assertFalse("Query shouldn't be equal, because different index readers ",
+ assertFalse("Query shouldn't be equal, because new join values have been indexed",
x.equals(JoinUtil.createJoinQuery(joinField, multiValued, joinField,
Integer.class, new TermQuery(new Term("name", "name5")),
indexSearcher, scoreMode1)));