You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/05/29 10:06:53 UTC

[Bug 119512] New: [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

https://issues.apache.org/ooo/show_bug.cgi?id=119512

          Priority: P3
            Bug ID: 119512
          Assignee: ooo-issues@incubator.apache.org
           Summary: [From Symphony] Import file created by MS Excel, if
                    there is blank item selected in Page filed of Pivot
                    Table, the selection will be lost.
          Severity: major
        Issue Type: DEFECT
    Classification: Application
                OS: All
          Reporter: shanzhu33@gmail.com
          Hardware: PC
            Status: UNCONFIRMED
           Version: AOO340
         Component: open-import
           Product: spreadsheet

Created attachment 77713
  --> https://issues.apache.org/ooo/attachment.cgi?id=77713&action=edit
.xlsx file with blank item in Page field of Pivot table

Build info: AOO3.4_r1327774

Open the .xlsx sample file attached in AOO.
(In the sample file, the "(blank)" item has been selected in Page fields of 3
Pivot tables)

Defect:
All the selection in Page field will be changed into "All" after importing
.xlsx into AOO.
The Page field can not support the "blank" item in it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

zhang jianfang <zh...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
                 CC|                            |zhangjf@apache.org
         Resolution|---                         |FIXED
           Assignee|ooo-issues@incubator.apache |zhangjf@apache.org
                   |.org                        |
   Target Milestone|---                         |AOO 3.5.0

--- Comment #8 from zhang jianfang <zh...@apache.org> ---
Change to resolved state

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

Yolanda Zhang Ying <tl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tldyzem@gmail.com

--- Comment #4 from Yolanda Zhang Ying <tl...@gmail.com> ---
Review comments:

In the patch, does aSelectedPage has other scenario that will be null string
besides empty field be selected?

if( const PivotCacheItem* pSharedItem = pCacheField->getCacheItem( nCacheItem )
)
{

      OUString aSelectedPage = pSharedItem->getName();
      OUString aSelectedPage = pSharedItem->getName();
      aPropSet.setProperty( PROP_SelectedPage, aSelectedPage );
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

bjcheny <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79199|                            |review?
              Flags|                            |

--- Comment #2 from bjcheny <co...@gmail.com> ---
Created attachment 79199
  --> https://issues.apache.org/ooo/attachment.cgi?id=79199&action=edit
patch for blank item in page filter from pivot table in xlsx

Sometimes, it's possible for page filter to select empty field.
Thus, it's unnecessary to limit value for page filter to be not NULL.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

--- Comment #6 from Yolanda Zhang Ying <tl...@gmail.com> ---
(In reply to comment #5)
> Not found so far based on current knowledge.
> 
> 
> (In reply to comment #4)
> > Review comments:
> > 
> > In the patch, does aSelectedPage has other scenario that will be null string
> > besides empty field be selected?
> > 
> > if( const PivotCacheItem* pSharedItem = pCacheField->getCacheItem(
> > nCacheItem ) )
> > {
> > 
> >       OUString aSelectedPage = pSharedItem->getName();
> >       OUString aSelectedPage = pSharedItem->getName();
> >       aPropSet.setProperty( PROP_SelectedPage, aSelectedPage );
> > }

Thx, I think it's ok to fix as it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

Shan Zhu <sh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--- Comment #1 from Shan Zhu <sh...@gmail.com> ---
Verified in AOO3.4.1_r1354891. Change status into Confirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

--- Comment #3 from bjcheny <co...@gmail.com> ---
However, I strongly suggest some string in UI like "empty" to indicate that
"empty" is selected as page filter. It helps user understand this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

--- Comment #7 from SVN Robot <sv...@dev.null.org> ---
"zhangjf" committed SVN revision 1383888 into trunk:
#i119512#, when importing MS Excel, if there is blank item selected in page
f...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 119512] [From Symphony] Import file created by MS Excel, if there is blank item selected in Page filed of Pivot Table, the selection will be lost.

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=119512

--- Comment #5 from bjcheny <co...@gmail.com> ---
Not found so far based on current knowledge.


(In reply to comment #4)
> Review comments:
> 
> In the patch, does aSelectedPage has other scenario that will be null string
> besides empty field be selected?
> 
> if( const PivotCacheItem* pSharedItem = pCacheField->getCacheItem(
> nCacheItem ) )
> {
> 
>       OUString aSelectedPage = pSharedItem->getName();
>       OUString aSelectedPage = pSharedItem->getName();
>       aPropSet.setProperty( PROP_SelectedPage, aSelectedPage );
> }

-- 
You are receiving this mail because:
You are the assignee for the bug.