[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5330: [Frontend][TFLite] support for FILL and SPLIT_V operators

[GitBox <gi...@apache.org>]

u99127 commented on a change in pull request #5330:
URL: https://github.com/apache/incubator-tvm/pull/5330#discussion_r413943986



##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -1067,6 +1069,27 @@ def convert_zeros_like(self, op):
 
         return out
 
+    def convert_fill(self, op):
+        """Convert TFLite FILL"""
+        try:
+            from tflite.Operator import Operator
+        except ImportError:
+            raise ImportError("The tflite package must be installed")
+

Review comment:
       Please drop this , it's no longer needed as the assert has now been commonised.

##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -1488,6 +1511,41 @@ def convert_split(self, op):
 
         return out
 
+    def convert_split_v(self, op):
+        """SPLIT_V implementation."""
+        try:
+            from tflite.Operator import Operator
+        except ImportError:
+            raise ImportError("The tflite package must be installed")
+
+        assert isinstance(op, Operator)

Review comment:
       Likewise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org