[GitHub] DaanHoogland commented on a change in pull request #2637: config drive - send user-defined vm name as host name, not uuid

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2637: config drive - send user-defined vm name as host name, not uuid
URL: https://github.com/apache/cloudstack/pull/2637#discussion_r187600417
 
 

 ##########
 File path: server/test/com/cloud/network/element/ConfigDriveNetworkElementTest.java
 ##########
 @@ -166,6 +166,7 @@ public void setUp() throws NoSuchFieldException, IllegalAccessException {
         when(virtualMachine.getDataCenterId()).thenReturn(DATACENTERID);
         when(virtualMachine.getInstanceName()).thenReturn(VMINSTANCENAME);
         when(virtualMachine.getUserData()).thenReturn(VMUSERDATA);
+        when(virtualMachine.getHostName()).thenReturn("vm-hostname");
 
 Review comment:
   can you externalise this string (like the ones above)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services