You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/05/26 04:14:22 UTC

[kudu-CR](branch-1.17.x) [examples] make client examples-test.sh pass

Hello Kudu Jenkins, Abhishek Chennaka,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/19941

to review the following change.


Change subject: [examples] make client_examples-test.sh pass
......................................................................

[examples] make client_examples-test.sh pass

Since the newly introduced non_unique_primary_key.cc example uses
features not available in C++98, an extra flag is needed if compiling
the example with legacy compilers.  Otherwise, client_examples-test.sh
would fail while trying to compile it.

Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Reviewed-on: http://gerrit.cloudera.org:8080/19766
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Kudu Jenkins
---
M examples/cpp/CMakeLists.txt
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/19941/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19941
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.17.x) [examples] make client examples-test.sh pass

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19941 )

Change subject: [examples] make client_examples-test.sh pass
......................................................................


Patch Set 1:

> Removed Verified-1 by Kudu Jenkins (120)
> 
remove the flaky test LogRollingITest.TestLogCleanupOnStartup


-- 
To view, visit http://gerrit.cloudera.org:8080/19941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19941
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 26 May 2023 08:23:17 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [examples] make client examples-test.sh pass

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19941 )

Change subject: [examples] make client_examples-test.sh pass
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19941
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 26 May 2023 21:40:25 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [examples] make client examples-test.sh pass

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.

Change subject: [examples] make client_examples-test.sh pass
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/19941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19941
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.17.x) [examples] make client examples-test.sh pass

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19941 )

Change subject: [examples] make client_examples-test.sh pass
......................................................................


Patch Set 1: Verified+1 Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19941
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 26 May 2023 08:22:32 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [examples] make client examples-test.sh pass

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19941 )

Change subject: [examples] make client_examples-test.sh pass
......................................................................

[examples] make client_examples-test.sh pass

Since the newly introduced non_unique_primary_key.cc example uses
features not available in C++98, an extra flag is needed if compiling
the example with legacy compilers.  Otherwise, client_examples-test.sh
would fail while trying to compile it.

Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Reviewed-on: http://gerrit.cloudera.org:8080/19766
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/19941
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M examples/cpp/CMakeLists.txt
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Yingchun Lai: Looks good to me, but someone else must approve; Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cc2e60372b5ff855316a3286662d2f148f9ce7c
Gerrit-Change-Number: 19941
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>