[GitHub] [spark] cloud-fan commented on a change in pull request #34826: [SPARK-37564][SQL] Add code-gen for sort aggregate without grouping keys

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34826:
URL: https://github.com/apache/spark/pull/34826#discussion_r771118522



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
##########
@@ -47,7 +47,8 @@ trait CodegenSupport extends SparkPlan {
 
   /** Prefix used in the current operator's variable names. */
   private def variablePrefix: String = this match {
-    case _: HashAggregateExec => "agg"
+    case _: HashAggregateExec => "hagg"

Review comment:
       I think `hashAgg` is better as it's clear and not very long.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org