git commit: [#5896] reverse sort the list we're del-iterating through, so the right idxs are deleted

[br...@apache.org]

Updated Branches:
  refs/heads/db/5896 [created] fa9a8b21a


[#5896] reverse sort the list we're del-iterating through, so the right idxs are deleted


Project: http://git-wip-us.apache.org/repos/asf/incubator-allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-allura/commit/fa9a8b21
Tree: http://git-wip-us.apache.org/repos/asf/incubator-allura/tree/fa9a8b21
Diff: http://git-wip-us.apache.org/repos/asf/incubator-allura/diff/fa9a8b21

Branch: refs/heads/db/5896
Commit: fa9a8b21a43b5d3877caeb729dd9df2acc98bd58
Parents: 31571da
Author: Dave Brondsema <db...@geek.net>
Authored: Wed Mar 6 17:23:44 2013 +0000
Committer: Dave Brondsema <db...@geek.net>
Committed: Wed Mar 6 17:23:44 2013 +0000

----------------------------------------------------------------------
 ForgeTracker/forgetracker/widgets/ticket_form.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-allura/blob/fa9a8b21/ForgeTracker/forgetracker/widgets/ticket_form.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/widgets/ticket_form.py b/ForgeTracker/forgetracker/widgets/ticket_form.py
index 25bd1bd..8bcff99 100644
--- a/ForgeTracker/forgetracker/widgets/ticket_form.py
+++ b/ForgeTracker/forgetracker/widgets/ticket_form.py
@@ -34,7 +34,7 @@ class GenericTicketForm(ew.SimpleForm):
         ctx = self.context_for(field)
         if idx == '_milestone':
             milestone_value = ctx.value
-            for milestone in field.options:
+            for milestone in field.options[::-1]:  # reverse so del hits the correct indexes
                 if milestone.complete and (milestone.py_value != milestone_value):
                     del field.options[field.options.index(milestone)]
             ctx = self.context_for(field)