You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/02/26 02:41:26 UTC

Review Request 31453: Run python style checks before unit tests in build.sh.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31453/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.


Repository: aurora


Description
-------

No major gain here, but when iterating locally, it's nice to not wait ~10 minutes to get a style error.


Diffs
-----

  build-support/jenkins/build.sh 61b5760f0b1e857bfd247b6488d6a7e9638aa679 

Diff: https://reviews.apache.org/r/31453/diff/


Testing
-------


Thanks,

Bill Farner


Re: Review Request 31453: Run python style checks before unit tests in build.sh.

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31453/#review74197
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On Feb. 25, 2015, 5:41 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31453/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 5:41 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> No major gain here, but when iterating locally, it's nice to not wait ~10 minutes to get a style error.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 61b5760f0b1e857bfd247b6488d6a7e9638aa679 
> 
> Diff: https://reviews.apache.org/r/31453/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Re: Review Request 31453: Run python style checks before unit tests in build.sh.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31453/#review74186
-----------------------------------------------------------

Ship it!


Master (9442e08) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 26, 2015, 1:41 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31453/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 1:41 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> No major gain here, but when iterating locally, it's nice to not wait ~10 minutes to get a style error.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 61b5760f0b1e857bfd247b6488d6a7e9638aa679 
> 
> Diff: https://reviews.apache.org/r/31453/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>