You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/04/16 20:51:35 UTC

[GitHub] [beam] boyuanzz commented on a change in pull request #14276: [BEAM-12021] Remove portability overrides from runner v1 overrides in DataflowRunner

boyuanzz commented on a change in pull request #14276:
URL: https://github.com/apache/beam/pull/14276#discussion_r615116090



##########
File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java
##########
@@ -1334,57 +1329,6 @@ public void testTransformTranslator() throws IOException {
     assertTrue(transform.translated);
   }
 
-  @Test
-  public void testSdkHarnessConfiguration() throws IOException {

Review comment:
       This test seems to check whether the environment id and docker url are populated correctly in beam fnapi proto. I think we want to keep this test. But we can remove `use_runner_v2 ` from the test setup because of the dual job submission.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org