You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/06/14 17:55:12 UTC
[Impala-ASF-CR] [tools] Add option to disable Python3 testing
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18624
Change subject: [tools] Add option to disable Python3 testing
......................................................................
[tools] Add option to disable Python3 testing
An internal test environment is not yet able to configure python3. Adds
an environment variable to disable configuring and testing with python3.
Change-Id: I00999090eb3732a10e114f368b47036131252474
---
M CMakeLists.txt
M tests/shell/util.py
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/18624/1
--
To view, visit http://gerrit.cloudera.org:8080/18624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00999090eb3732a10e114f368b47036131252474
Gerrit-Change-Number: 18624
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] [tools] Add option to disable Python3 testing
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18624 )
Change subject: [tools] Add option to disable Python3 testing
......................................................................
Patch Set 2: Code-Review+2
Thanks for putting this together. This makes sense as a way to support machines that don't have Python3 installed.
--
To view, visit http://gerrit.cloudera.org:8080/18624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00999090eb3732a10e114f368b47036131252474
Gerrit-Change-Number: 18624
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jun 2022 19:17:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add option to disable Python3 testing
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18624 )
Change subject: [tools] Add option to disable Python3 testing
......................................................................
[tools] Add option to disable Python3 testing
An internal test environment is not yet able to configure python3. Adds
an environment variable to disable configuring and testing with python3.
Tested manually with
```
make impala_shell_pypi
impala-py.test tests/shell/test_shell_interactive.py
rm -rf shell/build
export DISABLE_PYTHON3_TEST=true
touch CMakeLists.txt && make impala_shell_pypi
impala-py.test tests/shell/test_shell_interactive.py
```
Change-Id: I00999090eb3732a10e114f368b47036131252474
Reviewed-on: http://gerrit.cloudera.org:8080/18624
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M CMakeLists.txt
M tests/shell/util.py
2 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I00999090eb3732a10e114f368b47036131252474
Gerrit-Change-Number: 18624
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] [tools] Add option to disable Python3 testing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18624 )
Change subject: [tools] Add option to disable Python3 testing
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8233/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00999090eb3732a10e114f368b47036131252474
Gerrit-Change-Number: 18624
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jun 2022 18:20:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add option to disable Python3 testing
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18624
to look at the new patch set (#2).
Change subject: [tools] Add option to disable Python3 testing
......................................................................
[tools] Add option to disable Python3 testing
An internal test environment is not yet able to configure python3. Adds
an environment variable to disable configuring and testing with python3.
Tested manually with
```
make impala_shell_pypi
impala-py.test tests/shell/test_shell_interactive.py
rm -rf shell/build
export DISABLE_PYTHON3_TEST=true
touch CMakeLists.txt && make impala_shell_pypi
impala-py.test tests/shell/test_shell_interactive.py
```
Change-Id: I00999090eb3732a10e114f368b47036131252474
---
M CMakeLists.txt
M tests/shell/util.py
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/18624/2
--
To view, visit http://gerrit.cloudera.org:8080/18624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00999090eb3732a10e114f368b47036131252474
Gerrit-Change-Number: 18624
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] [tools] Add option to disable Python3 testing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18624 )
Change subject: [tools] Add option to disable Python3 testing
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10767/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00999090eb3732a10e114f368b47036131252474
Gerrit-Change-Number: 18624
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jun 2022 18:15:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [tools] Add option to disable Python3 testing
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18624 )
Change subject: [tools] Add option to disable Python3 testing
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00999090eb3732a10e114f368b47036131252474
Gerrit-Change-Number: 18624
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jun 2022 22:58:05 +0000
Gerrit-HasComments: No