You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/11/14 00:28:46 UTC
[kudu-CR] Add the ability to enable xray instrumentation
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8537
to review the following change.
Change subject: Add the ability to enable xray instrumentation
......................................................................
Add the ability to enable xray instrumentation
Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8537/1
--
To view, visit http://gerrit.cloudera.org:8080/8537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
Gerrit-Change-Number: 8537
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] Add the ability to enable xray instrumentation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8537 )
Change subject: Add the ability to enable xray instrumentation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8537/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/8537/1/CMakeLists.txt@333
PS1, Line 333: if (${KUDU_USE_XRAY})
: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fxray-instrument")
: endif()
Should this depend on the type and version of the compiler used (i.e., don't enable that for gcc and clang < v3.9?)
--
To view, visit http://gerrit.cloudera.org:8080/8537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
Gerrit-Change-Number: 8537
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 14 Nov 2017 01:28:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add the ability to enable xray instrumentation
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8537 )
Change subject: Add the ability to enable xray instrumentation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
Gerrit-Change-Number: 8537
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 14 Nov 2017 19:06:19 +0000
Gerrit-HasComments: No
[kudu-CR] Add the ability to enable xray instrumentation
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8537 )
Change subject: Add the ability to enable xray instrumentation
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8537/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/8537/1/CMakeLists.txt@333
PS1, Line 333: if (${KUDU_USE_XRAY})
: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fxray-instrument")
: endif()
> Should this depend on the type and version of the compiler used (i.e., don'
i think if you set this, it's your own fault if the compiler barfs with "I dont understand -fxray-instrument" rather than us trying to do version-based checking here
--
To view, visit http://gerrit.cloudera.org:8080/8537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
Gerrit-Change-Number: 8537
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 14 Nov 2017 01:37:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] Add the ability to enable xray instrumentation
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8537 )
Change subject: Add the ability to enable xray instrumentation
......................................................................
Add the ability to enable xray instrumentation
Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
Reviewed-on: http://gerrit.cloudera.org:8080/8537
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
Gerrit-Change-Number: 8537
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add the ability to enable xray instrumentation
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8537 )
Change subject: Add the ability to enable xray instrumentation
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8537/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/8537/1/CMakeLists.txt@333
PS1, Line 333: endif()
: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -DADDRESS_SANITIZER")
: endif()
> i think if you set this, it's your own fault if the compiler barfs with "I
sgtm
--
To view, visit http://gerrit.cloudera.org:8080/8537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a8d5a27912e3b8d4db97b05906cbe7e87ba2cc8
Gerrit-Change-Number: 8537
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 14 Nov 2017 01:49:31 +0000
Gerrit-HasComments: Yes