You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by vipul1409 <gi...@git.apache.org> on 2017/05/09 16:18:35 UTC

[GitHub] zeppelin pull request #2326: [ZEPPELIN-2519] Disable watchers not in viewpor...

GitHub user vipul1409 opened a pull request:

    https://github.com/apache/zeppelin/pull/2326

    [ZEPPELIN-2519] Disable watchers not in viewport

    ### What is this PR for?
    Currently all the watchers are enabled by default. I came across this github project https://github.com/wix/angular-viewport-watch to disable watchers not in viewport. This reduces number of watchers in notebooks with large number of paragraphs.
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2519
    
    ### How should this be tested?
    Outline the steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    Not sure of this part. This is under MIT license. [Project link](https://github.com/wix/angular-viewport-watch)
    
    * Is there breaking changes for older versions?
    No
    
    * Does this needs documentation?
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vipul1409/zeppelin ZEPPELIN-2519

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2326
    
----
commit 329e33a27b28b494f739c0d569bb4ea752e9044a
Author: vipulm <vi...@qubole.com>
Date:   2017-05-09T15:29:21Z

    Disable watchers not in viewport

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by vipul1409 <gi...@git.apache.org>.

Github user vipul1409 commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    Any suggestions on why jenkins job is failing? On checking in jenkins console output I don't see any smaller job failing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    You can close and reopen this PR to trigger jenkins again (not travis). 
    
    I will test and comment soon. Thanks for update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by vipul1409 <gi...@git.apache.org>.

Github user vipul1409 commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    Addressed review comments and moved the dependency to npm. One jenkins job is failing but looks unrelated to my changes. I also see build is marked as failed in master, just double checking if master build is also broken.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    Thanks @vipul1409 for great contribution.
    Thanks @1ambda for the review.
    
    Merge to master if no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    Hi @vipul1409, This PR occurs an error like
    
    ```js
    TypeError: Cannot read property 'create' of undefined
        at Object.link (http://localhost:9001/app.bundle.js:9662:52)
        at http://localhost:9001/bower_components/angular/angular.js:1240:18
        at invokeLinkFn (http://localhost:9001/bower_components/angular/angular.js:9814:9)
        at nodeLinkFn (http://localhost:9001/bower_components/angular/angular.js:9215:11)
        at compositeLinkFn (http://localhost:9001/bower_components/angular/angular.js:8510:13)
        at publicLinkFn (http://localhost:9001/bower_components/angular/angular.js:8390:30)
        at lazyCompilation (http://localhost:9001/bower_components/angular/angular.js:8728:25)
        at boundTranscludeFn (http://localhost:9001/bower_components/angular/angular.js:8527:16)
        at controllersBoundTransclude (http://localhost:9001/bower_components/angular/angular.js:9265:20)
        at ngRepeatAction (http://localhost:9001/bower_components/angular/angular.js:29607:15) <div id="{{currentParagraph.id}}_paragraphColumn_main" ng-repeat="currentParagraph in note.paragraphs" ng-controller="ParagraphCtrl" ng-init="init(currentParagraph, note)" ng-class="columnWidthClass(currentParagraph.config.colWidth)" style="margin: 0; padding: 0;" viewport-watch="" class="ng-scope" data-ng-animate="1">
    ```
    
    When I remove `viewport-watch` directive from `notebook.html`, there is no error.
    Could you fix it?
    
    
    ![image](https://cloud.githubusercontent.com/assets/4968473/26710441/d7940e48-4794-11e7-9b1f-d16462acc49e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    Tested and works well (both in frontend, backend angular APIs).
    
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by vipul1409 <gi...@git.apache.org>.

Github user vipul1409 commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    Fixed all the issues and the tests have also passed. Please let me know if any more details are needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport

Posted by vipul1409 <gi...@git.apache.org>.

Github user vipul1409 commented on the issue:

    https://github.com/apache/zeppelin/pull/2326
  
    Hi Kun,
    
    Raised this PR for the fix.
    https://github.com/apache/zeppelin/pull/2392/files
    
    Regards,
    
    On Thu, Jun 1, 2017 at 9:11 PM, Kun <no...@github.com> wrote:
    
    > Hi @vipul1409 <https://github.com/vipul1409>, This PR occurs an error like
    >
    > TypeError: Cannot read property 'create' of undefined
    >     at Object.link (http://localhost:9001/app.bundle.js:9662:52)
    >     at http://localhost:9001/bower_components/angular/angular.js:1240:18
    >     at invokeLinkFn (http://localhost:9001/bower_components/angular/angular.js:9814:9)
    >     at nodeLinkFn (http://localhost:9001/bower_components/angular/angular.js:9215:11)
    >     at compositeLinkFn (http://localhost:9001/bower_components/angular/angular.js:8510:13)
    >     at publicLinkFn (http://localhost:9001/bower_components/angular/angular.js:8390:30)
    >     at lazyCompilation (http://localhost:9001/bower_components/angular/angular.js:8728:25)
    >     at boundTranscludeFn (http://localhost:9001/bower_components/angular/angular.js:8527:16)
    >     at controllersBoundTransclude (http://localhost:9001/bower_components/angular/angular.js:9265:20)
    >     at ngRepeatAction (http://localhost:9001/bower_components/angular/angular.js:29607:15) <div id="{{currentParagraph.id}}_paragraphColumn_main" ng-repeat="currentParagraph in note.paragraphs" ng-controller="ParagraphCtrl" ng-init="init(currentParagraph, note)" ng-class="columnWidthClass(currentParagraph.config.colWidth)" style="margin: 0; padding: 0;" viewport-watch="" class="ng-scope" data-ng-animate="1">
    >
    > When I remove viewport-watch directive from notebook.html, there is no
    > error.
    > Could you fix it?
    >
    > [image: image]
    > <https://cloud.githubusercontent.com/assets/4968473/26710441/d7940e48-4794-11e7-9b1f-d16462acc49e.png>
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/zeppelin/pull/2326#issuecomment-305684549>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/ABpFHmRfDYpbbu_O4gDWD4w6K9FJCgaYks5r_4tugaJpZM4NVjZF>
    > .
    >
    
    
    
    -- 
    Vipul Modi
    Software Development Engineer 2
    Flipkart Internet Pvt. Ltd.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---