[GitHub] sijie opened a new pull request #1308: longPollThreadPool can not be null

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1308:  longPollThreadPool can not be null
URL: https://github.com/apache/bookkeeper/pull/1308
 
 
   Descriptions of the changes in this PR:
   
   *Problem*
   
   The long polling logic is built with the assumption that there is a thread pool for scheduling deferred reads.
   So if people happens to set `numLongPollWorkerThreads` to zero or negative, a null value is passed into long poll requests which causes NPE.
   
   *Solution*
   
   If `numLongPollWorkerThreads` is set to zero or negative, fall back to use read thread pool. If there is no read thread pool, create a thread pool
   aligned with num processors.
   
   With this change, turn the default value of `long poll threads` to zero. so no additional threads are needed to be created if long poll feature is not used (e.g. at pulsar).
   
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services