You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Uri Silberstein (JIRA)" <ji...@apache.org> on 2017/10/02 12:25:01 UTC

[jira] [Created] (BEAM-3006) Minor fix in PipelineTest.testReplacedNames()

Uri Silberstein created BEAM-3006:
-------------------------------------

             Summary: Minor fix in PipelineTest.testReplacedNames()
                 Key: BEAM-3006
                 URL: https://issues.apache.org/jira/browse/BEAM-3006
             Project: Beam
          Issue Type: Test
          Components: sdk-java-core
            Reporter: Uri Silberstein
            Assignee: Kenneth Knowles
            Priority: Minor


This method tests the pipeline replace functionality. 
It does so by replacing a OriginalTransform with ReplacementTransform and then assert that the pipeline contains the ReplacementTransform by assert the transformation name.

The problem is that both transformations (OriginalTransform and ReplacementTransform) have the same transformation name. So the assert doesn't really checks a thing 

The offered fix:
Changing the names to "original_name" and "replacement_name" respectively and then asserting that transformation name is "replacement_name" and not "original_name"




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)