You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Willem Jiang <wi...@gmail.com> on 2009/03/09 08:31:18 UTC

Re: svn commit: r751567 - in /cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/tools: XMLBeansSchemaTypeUtils.java XMLBeansToolingDataBinding.java

Hi Glen,

Thanks for pointing out those errors, I will fix them in my next commit.

Willem

Glen Mazza wrote:
> I think you mean "BUILTIN_TYPES_MAP", not "BUILDIN_TYPES_MAP".  Also
> note the duplication below.
> 
> Glen
> 
> 
> On Mon, 2009-03-09 at 01:27 +0000, ningjiang@apache.org wrote:
>> Author: ningjiang
>> Date: Mon Mar  9 01:27:58 2009
>> New Revision: 751567
>>
>> URL: http://svn.apache.org/viewvc?rev=751567&view=rev
>> Log:
>> CXF-2095 mapping the XmlBeans buildin type into the natural Java class
>> when getting the wrapped element types
>>
>> Added:
>>
>> cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/tools/XMLBeansSchemaTypeUtils.java   (with props)
>> Modified:
>>
>> cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/tools/XMLBeansToolingDataBinding.java
>>
>> Added:
>> cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/tools/XMLBeansSchemaTypeUtils.java
>> URL:
>> http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/tools/XMLBeansSchemaTypeUtils.java?rev=751567&view=auto
>> ==============================================================================
>> --- +/**
>> + * This class will help us to map the XMLBeansBuildinType into Natural Java Type
>> + */
>> +public final class XMLBeansSchemaTypeUtils {
>> +    private static final Map<String, String> BUILDIN_TYPES_MAP;
>> +    static {
>> +        BUILDIN_TYPES_MAP = new HashMap<String, String>();
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlObject", "org.apache.xmlbeans.XmlObject");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlAnySimpleType", "String");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlAnyURI", "String");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlBase64Binary", "byte[]");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlBoolean", "boolean");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlByte", "byte");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlDate", "java.util.Calendar");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlDateTime", "java.util.Calendar");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlDecimal", "java.math.BigDecimal");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlDouble", "double");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlDuration", "org.apache.xmlbeans.GDuration");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlENTITIES", "String");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlENTITY", "String");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlFloat", "float");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlGDay", "java.util.Calendar");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlGMonth", "java.util.Calendar");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlGMonthDay", "java.util.Calendar");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlGYear", "java.util.Calendar");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlHexBinary", "java.util.Calendar");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlHexBinary", "byte[]");
> 
> Error here?  You have the above XmlHexBinary duplicated.
> 
> 
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlID", "String");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlIDREF", "String");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlIDREFS", "String");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlInt", "int");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlInteger", "java.math.BigInteger");
>> +        BUILDIN_TYPES_MAP.put("org.apache.xmlbeans.XmlLanguage", "String");
> 
> 
>