You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2018/03/17 02:17:59 UTC
Review Request 66127: HIVE-18982: Provide a CLI option to manually
trigger failover
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66127/
-----------------------------------------------------------
Review request for hive and Sergey Shelukhin.
Bugs: HIVE-18982
https://issues.apache.org/jira/browse/HIVE-18982
Repository: hive-git
Description
-------
HIVE-18982: Provide a CLI option to manually trigger failover
Diffs
-----
bin/ext/hiveserver2.sh 1e94542befc9b86b739a0031956e71fbce711458
service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java 819ce198c54c95508dcbb85e89afb1e4418e85da
service/src/java/org/apache/hive/service/server/HiveServer2.java 5b792ac050ff1ae1eee4c145531864c6698ac214
service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java 33529edf7abf418f9129202fbd5cef84064b86a6
service/src/java/org/apache/hive/service/servlet/HS2Peers.java a51bbeb8e920f9c6936d25e31e20e40f78c72eb1
Diff: https://reviews.apache.org/r/66127/diff/1/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 66127: HIVE-18982: Provide a CLI option to manually
trigger failover
Posted by j....@gmail.com.
> On March 20, 2018, 6:59 p.m., Sergey Shelukhin wrote:
> > service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/66127/diff/2/?file=1982536#file1982536line46>
> >
> > hmm... some testing will be needed for this, esp for security. Is it practical to do in unit tests?
Added unit tests in the new patch.
- Prasanth_J
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66127/#review199567
-----------------------------------------------------------
On March 21, 2018, 7:31 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66127/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 7:31 a.m.)
>
>
> Review request for hive and Sergey Shelukhin.
>
>
> Bugs: HIVE-18982
> https://issues.apache.org/jira/browse/HIVE-18982
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18982: Provide a CLI option to manually trigger failover
>
>
> Diffs
> -----
>
> bin/ext/hiveserver2.sh 1e94542
> common/src/java/org/apache/hive/http/HttpServer.java 71b2668
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java 72b2a8c
> itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java e1c2dd0
> service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java 7c75489
> service/src/java/org/apache/hive/service/server/HiveServer2.java bb92c44
> service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java 33529ed
> service/src/java/org/apache/hive/service/servlet/HS2Peers.java a51bbeb
> service/src/test/org/apache/hive/service/server/TestHS2HttpServerPam.java d1b3ce0
>
>
> Diff: https://reviews.apache.org/r/66127/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 66127: HIVE-18982: Provide a CLI option to manually
trigger failover
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66127/#review199567
-----------------------------------------------------------
service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java
Lines 46 (patched)
<https://reviews.apache.org/r/66127/#comment279870>
hmm... some testing will be needed for this, esp for security. Is it practical to do in unit tests?
- Sergey Shelukhin
On March 19, 2018, 6:52 p.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66127/
> -----------------------------------------------------------
>
> (Updated March 19, 2018, 6:52 p.m.)
>
>
> Review request for hive and Sergey Shelukhin.
>
>
> Bugs: HIVE-18982
> https://issues.apache.org/jira/browse/HIVE-18982
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18982: Provide a CLI option to manually trigger failover
>
>
> Diffs
> -----
>
> bin/ext/hiveserver2.sh 1e94542
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java 72b2a8c
> service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java 819ce19
> service/src/java/org/apache/hive/service/server/HiveServer2.java bb92c44
> service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java 33529ed
> service/src/java/org/apache/hive/service/servlet/HS2Peers.java a51bbeb
>
>
> Diff: https://reviews.apache.org/r/66127/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
Re: Review Request 66127: HIVE-18982: Provide a CLI option to manually
trigger failover
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66127/
-----------------------------------------------------------
(Updated March 21, 2018, 7:31 a.m.)
Review request for hive and Sergey Shelukhin.
Changes
-------
Auth updates
Bugs: HIVE-18982
https://issues.apache.org/jira/browse/HIVE-18982
Repository: hive-git
Description
-------
HIVE-18982: Provide a CLI option to manually trigger failover
Diffs (updated)
-----
bin/ext/hiveserver2.sh 1e94542
common/src/java/org/apache/hive/http/HttpServer.java 71b2668
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java 72b2a8c
itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java e1c2dd0
service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java 7c75489
service/src/java/org/apache/hive/service/server/HiveServer2.java bb92c44
service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java 33529ed
service/src/java/org/apache/hive/service/servlet/HS2Peers.java a51bbeb
service/src/test/org/apache/hive/service/server/TestHS2HttpServerPam.java d1b3ce0
Diff: https://reviews.apache.org/r/66127/diff/3/
Changes: https://reviews.apache.org/r/66127/diff/2-3/
Testing
-------
Thanks,
Prasanth_J
Re: Review Request 66127: HIVE-18982: Provide a CLI option to manually
trigger failover
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66127/
-----------------------------------------------------------
(Updated March 19, 2018, 6:52 p.m.)
Review request for hive and Sergey Shelukhin.
Changes
-------
Added comments + tests.
Bugs: HIVE-18982
https://issues.apache.org/jira/browse/HIVE-18982
Repository: hive-git
Description
-------
HIVE-18982: Provide a CLI option to manually trigger failover
Diffs (updated)
-----
bin/ext/hiveserver2.sh 1e94542
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestActivePassiveHA.java 72b2a8c
service/src/java/org/apache/hive/service/server/HS2ActivePassiveHARegistry.java 819ce19
service/src/java/org/apache/hive/service/server/HiveServer2.java bb92c44
service/src/java/org/apache/hive/service/servlet/HS2LeadershipStatus.java 33529ed
service/src/java/org/apache/hive/service/servlet/HS2Peers.java a51bbeb
Diff: https://reviews.apache.org/r/66127/diff/2/
Changes: https://reviews.apache.org/r/66127/diff/1-2/
Testing
-------
Thanks,
Prasanth_J