You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2005/09/28 23:14:14 UTC

svn commit: r292304 - in /myfaces/share/trunk/src/java/org/apache/myfaces/renderkit: JSFAttr.java html/HtmlButtonRendererBase.java

Author: mmarinschek
Date: Wed Sep 28 14:14:09 2005
New Revision: 292304

URL: http://svn.apache.org/viewcvs?rev=292304&view=rev
Log:
Played with JavaScript in renderers, apart from this minor changes.

Modified:
    myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/JSFAttr.java
    myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlButtonRendererBase.java

Modified: myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/JSFAttr.java
URL: http://svn.apache.org/viewcvs/myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/JSFAttr.java?rev=292304&r1=292303&r2=292304&view=diff
==============================================================================
--- myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/JSFAttr.java (original)
+++ myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/JSFAttr.java Wed Sep 28 14:14:09 2005
@@ -45,6 +45,7 @@
     // Common Input Attributes
     public static final String   REQUIRED_ATTR                  = "required";
     public static final String   VALIDATOR_ATTR                 = "validator";
+    public static final String   DISABLED_ATTR                  = "disabled";
 
     // Input_Secret Attributes
     public static final String   REDISPLAY_ATTR                 = "redisplay";

Modified: myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlButtonRendererBase.java
URL: http://svn.apache.org/viewcvs/myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlButtonRendererBase.java?rev=292304&r1=292303&r2=292304&view=diff
==============================================================================
--- myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlButtonRendererBase.java (original)
+++ myfaces/share/trunk/src/java/org/apache/myfaces/renderkit/html/HtmlButtonRendererBase.java Wed Sep 28 14:14:09 2005
@@ -80,14 +80,14 @@
 
         writer.startElement(HTML.INPUT_ELEM, uiComponent);
 
-        writer.writeAttribute(HTML.ID_ATTR, clientId, null);
-        writer.writeAttribute(HTML.NAME_ATTR, clientId, null);
+        writer.writeAttribute(HTML.ID_ATTR, clientId, JSFAttr.ID_ATTR);
+        writer.writeAttribute(HTML.NAME_ATTR, clientId, JSFAttr.ID_ATTR);
 
         String image = getImage(uiComponent);
 
         if (image != null)
         {
-            writer.writeAttribute(HTML.TYPE_ATTR, HTML.INPUT_TYPE_IMAGE, null);
+            writer.writeAttribute(HTML.TYPE_ATTR, HTML.INPUT_TYPE_IMAGE, JSFAttr.TYPE_ATTR);
             writer.writeAttribute(HTML.SRC_ATTR, image, JSFAttr.IMAGE_ATTR);
         }
         else
@@ -102,7 +102,7 @@
             Object value = getValue(uiComponent);
             if (value != null)
             {
-                writer.writeAttribute(HTML.VALUE_ATTR, value, null);
+                writer.writeAttribute(HTML.VALUE_ATTR, value, JSFAttr.VALUE_ATTR);
             }
         }
         if (JavascriptUtils.isJavascriptAllowed(facesContext.getExternalContext()))
@@ -120,7 +120,7 @@
 
         if (isDisabled(facesContext, uiComponent))
         {
-            writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
+            writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, JSFAttr.DISABLED_ATTR);
         }
 
         writer.endElement(HTML.INPUT_ELEM);