You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/21 12:24:45 UTC
[GitHub] [spark] beliefer opened a new pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
beliefer opened a new pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668
### What changes were proposed in this pull request?
1.Add version information to the configuration of `Deploy`.
2.Update the docs of `Deploy`.
### Why are the changes needed?
Supplemental configuration version information.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Exists UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589639568
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590666955
@HyukjinKwon Thanks for your help! @srowen Thanks for your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590166154
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23591/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589683638
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer edited a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915646
@HyukjinKwon `spark.deploy.recoveryMode.factory` appears in branch-1.3, but the version number in the `pom.xml` file corresponding to the commit is 1.2.0-SNAPSHOT. Is the since version of this configuration 1.2.0 or 1.3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589683653
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23546/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589926617
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118811/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084316
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
Review comment:
SPARK-1830 commit ID: deefd9d7377a8091a1d184b99066febd0e9f6afd#diff-29dffdccd5a7f4c8b496c293e87c8668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589753533
**[Test build #118795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118795/testReport)** for PR 27668 at commit [`2eec92e`](https://github.com/apache/spark/commit/2eec92e220e76360911f87710c4f1b0b3beb75bf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589633009
@HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084655
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590166154
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23591/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589912369
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589926472
**[Test build #118811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118811/testReport)** for PR 27668 at commit [`bd6416b`](https://github.com/apache/spark/commit/bd6416b4b015c5f9fd81f6ff4ccf838536bbfb9c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382866559
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
Ideally it might be better to leave a JIRA ID as a comment on each line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084620
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589913660
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23560/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer edited a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589633009
cc @HyukjinKwon I think we should also add version info for other modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589912272
**[Test build #118806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118806/testReport)** for PR 27668 at commit [`4e7ff54`](https://github.com/apache/spark/commit/4e7ff542c6398ad24bd5761a90341a04d3bfcdb0).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084673
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589897852
**[Test build #118806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118806/testReport)** for PR 27668 at commit [`4e7ff54`](https://github.com/apache/spark/commit/4e7ff542c6398ad24bd5761a90341a04d3bfcdb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084746
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
.intConf
.createWithDefault(15)
val MAX_EXECUTOR_RETRIES = ConfigBuilder("spark.deploy.maxExecutorRetries")
+ .version("1.6.3")
.intConf
.createWithDefault(10)
val SPREAD_OUT_APPS = ConfigBuilder("spark.deploy.spreadOut")
+ .version("0.6.1")
.booleanConf
.createWithDefault(true)
val DEFAULT_CORES = ConfigBuilder("spark.deploy.defaultCores")
+ .version("0.9.0")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589898021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23556/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084137
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084645
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589754486
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118795/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589634420
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23543/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590194948
**[Test build #118843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118843/testReport)** for PR 27668 at commit [`5891872`](https://github.com/apache/spark/commit/5891872e090d3a31ac4492073b5ff9177195b48f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589634100
**[Test build #118791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118791/testReport)** for PR 27668 at commit [`2eec92e`](https://github.com/apache/spark/commit/2eec92e220e76360911f87710c4f1b0b3beb75bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer edited a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589633009
cc @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589682888
**[Test build #118795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118795/testReport)** for PR 27668 at commit [`2eec92e`](https://github.com/apache/spark/commit/2eec92e220e76360911f87710c4f1b0b3beb75bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084634
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589682393
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382866302
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
The earliest version of the configuration item.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084655
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084137
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084137
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532#diff-29dffdccd5a7f4c8b496c293e87c8668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915746
**[Test build #118811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118811/testReport)** for PR 27668 at commit [`bd6416b`](https://github.com/apache/spark/commit/bd6416b4b015c5f9fd81f6ff4ccf838536bbfb9c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382869658
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
Many early commits did not have a jira ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590652478
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589926613
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589634412
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589634100
**[Test build #118791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118791/testReport)** for PR 27668 at commit [`2eec92e`](https://github.com/apache/spark/commit/2eec92e220e76360911f87710c4f1b0b3beb75bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915816
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23561/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382874015
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
yeah just commit url or hash anything is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589921622
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589897852
**[Test build #118806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118806/testReport)** for PR 27668 at commit [`4e7ff54`](https://github.com/apache/spark/commit/4e7ff542c6398ad24bd5761a90341a04d3bfcdb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084722
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
.intConf
.createWithDefault(15)
val MAX_EXECUTOR_RETRIES = ConfigBuilder("spark.deploy.maxExecutorRetries")
+ .version("1.6.3")
.intConf
.createWithDefault(10)
val SPREAD_OUT_APPS = ConfigBuilder("spark.deploy.spreadOut")
+ .version("0.6.1")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590165956
**[Test build #118843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118843/testReport)** for PR 27668 at commit [`5891872`](https://github.com/apache/spark/commit/5891872e090d3a31ac4492073b5ff9177195b48f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084316
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
Review comment:
SPARK-1830 commit ID: deefd9d7377a8091a1d184b99066febd0e9f6afd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589634420
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23543/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084673
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084686
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
Review comment:
No JIRA ID, commit ID: 46eecd110a4017ea0c86cbb1010d0ccd6a5eb2ef
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084620
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084645
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589912374
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118806/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589913660
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23560/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590195492
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118843/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590165956
**[Test build #118843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118843/testReport)** for PR 27668 at commit [`5891872`](https://github.com/apache/spark/commit/5891872e090d3a31ac4492073b5ff9177195b48f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589913656
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589639577
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118791/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589913547
**[Test build #118810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118810/testReport)** for PR 27668 at commit [`ee3cdd2`](https://github.com/apache/spark/commit/ee3cdd27c1e05a10dc851f6e6ef8252b6395bd39).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084673
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
Review comment:
No JIRA ID, commit ID: 7446f5ff93142d2dd5c79c63fa947f47a1d4db8b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084746
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
.intConf
.createWithDefault(15)
val MAX_EXECUTOR_RETRIES = ConfigBuilder("spark.deploy.maxExecutorRetries")
+ .version("1.6.3")
.intConf
.createWithDefault(10)
val SPREAD_OUT_APPS = ConfigBuilder("spark.deploy.spreadOut")
+ .version("0.6.1")
.booleanConf
.createWithDefault(true)
val DEFAULT_CORES = ConfigBuilder("spark.deploy.defaultCores")
+ .version("0.9.0")
Review comment:
No JIRA ID, commit ID: d8bcc8e9a095c1b20dd7a17b6535800d39bff80e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915815
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382869658
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
Many early commits did not have a JIRA ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589913547
**[Test build #118810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118810/testReport)** for PR 27668 at commit [`ee3cdd2`](https://github.com/apache/spark/commit/ee3cdd27c1e05a10dc851f6e6ef8252b6395bd39).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589634412
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589754475
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589912374
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118806/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915815
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590195486
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590166148
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590195492
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118843/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382876122
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084709
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
.intConf
.createWithDefault(15)
val MAX_EXECUTOR_RETRIES = ConfigBuilder("spark.deploy.maxExecutorRetries")
+ .version("1.6.3")
Review comment:
SPARK-16956, commit ID: ace458f0330f22463ecf7cbee7c0465e10fba8a8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589912369
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382677303
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
What is 0.8.1 here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589639531
**[Test build #118791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118791/testReport)** for PR 27668 at commit [`2eec92e`](https://github.com/apache/spark/commit/2eec92e220e76360911f87710c4f1b0b3beb75bf).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382870232
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
OK. But commit log is too long. Can I just add the URL corresponding to the commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590195486
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590166148
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589682888
**[Test build #118795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118795/testReport)** for PR 27668 at commit [`2eec92e`](https://github.com/apache/spark/commit/2eec92e220e76360911f87710c4f1b0b3beb75bf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589639568
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084655
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
Review comment:
No JIRA ID, commit ID: 46eecd110a4017ea0c86cbb1010d0ccd6a5eb2ef
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084634
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
Review comment:
No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084709
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
.intConf
.createWithDefault(15)
val MAX_EXECUTOR_RETRIES = ConfigBuilder("spark.deploy.maxExecutorRetries")
+ .version("1.6.3")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589898015
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084686
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
Review comment:
No JIRA ID, commit ID:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084316
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
Review comment:
SPARK-1830 commit ID: deefd9d7377a8091a1d184b99066febd0e9f6afd
This configuration appears in branch-1.3, but the version number in the pom.xml file corresponding to the commit is 1.2.0-SNAPSHOT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383068272
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1") // No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
Review comment:
Ah, it's okay to don't comment in the code. I meant to leave a Github PR comment for reviewers :-) .. thanks for leaving the traces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-590166688
@HyukjinKwon I have removed the comments and add GitHub comments for each item.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383083936
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1") // No JIRA ID, commit ID: d66c01f2b6defb3db6c1be99523b734a4d960532
Review comment:
OK. I have deleted it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589683653
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23546/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r383084722
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
.stringConf
.createWithDefault("NONE")
val RECOVERY_MODE_FACTORY = ConfigBuilder("spark.deploy.recoveryMode.factory")
+ .version("1.2.0")
.stringConf
.createWithDefault("")
val RECOVERY_DIRECTORY = ConfigBuilder("spark.deploy.recoveryDirectory")
+ .version("0.8.1")
.stringConf
.createWithDefault("")
val ZOOKEEPER_URL = ConfigBuilder("spark.deploy.zookeeper.url")
.doc(s"When `${RECOVERY_MODE.key}` is set to ZOOKEEPER, this " +
"configuration is used to set the zookeeper URL to connect to.")
+ .version("0.8.1")
.stringConf
.createOptional
val ZOOKEEPER_DIRECTORY = ConfigBuilder("spark.deploy.zookeeper.dir")
+ .version("0.8.1")
.stringConf
.createOptional
val RETAINED_APPLICATIONS = ConfigBuilder("spark.deploy.retainedApplications")
+ .version("0.8.0")
.intConf
.createWithDefault(200)
val RETAINED_DRIVERS = ConfigBuilder("spark.deploy.retainedDrivers")
+ .version("1.1.0")
.intConf
.createWithDefault(200)
val REAPER_ITERATIONS = ConfigBuilder("spark.dead.worker.persistence")
+ .version("0.8.0")
.intConf
.createWithDefault(15)
val MAX_EXECUTOR_RETRIES = ConfigBuilder("spark.deploy.maxExecutorRetries")
+ .version("1.6.3")
.intConf
.createWithDefault(10)
val SPREAD_OUT_APPS = ConfigBuilder("spark.deploy.spreadOut")
+ .version("0.6.1")
Review comment:
No JIRA ID, commit ID: bb2b9ff37cd2503cc6ea82c5dd395187b0910af0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589926617
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118811/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589683638
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589921623
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118810/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589921622
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589921623
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118810/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589913656
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589926613
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589639577
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118791/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589898015
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589898021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23556/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589754486
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118795/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915816
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23561/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589921563
**[Test build #118810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118810/testReport)** for PR 27668 at commit [`ee3cdd2`](https://github.com/apache/spark/commit/ee3cdd27c1e05a10dc851f6e6ef8252b6395bd39).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27668:
[WIP][SPARK-30887][CORE][DOC] Add version information to the configuration
of Deploy
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27668: [WIP][SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589754475
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915646
@HyukjinKwon `spark.deploy.recoveryMode.factory` appears in branch-1.3, but the version number in the pom.xml file corresponding to the commit is 1.2.0-SNAPSHOT. Is the since version of this configuration 1.2.0 or 1.3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27668:
[SPARK-30887][CORE][DOC] Add version information to the configuration of
Deploy
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#discussion_r382869792
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Deploy.scala
##########
@@ -19,48 +19,59 @@ package org.apache.spark.internal.config
private[spark] object Deploy {
val RECOVERY_MODE = ConfigBuilder("spark.deploy.recoveryMode")
+ .version("0.8.1")
Review comment:
You can show the commit log too. That should deduplicate the review overhead because probably reviewers should do exactly the same thing as you did to verify :-).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC]
Add version information to the configuration of Deploy
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27668: [SPARK-30887][CORE][DOC] Add version information to the configuration of Deploy
URL: https://github.com/apache/spark/pull/27668#issuecomment-589915746
**[Test build #118811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118811/testReport)** for PR 27668 at commit [`bd6416b`](https://github.com/apache/spark/commit/bd6416b4b015c5f9fd81f6ff4ccf838536bbfb9c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org