You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2024/02/02 03:00:43 UTC

[PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

mymeiyi opened a new pull request, #30739:
URL: https://github.com/apache/doris/pull/30739

   ## Proposed changes
   
   Pick https://github.com/apache/doris/pull/30635
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922754945

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.8 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c8c5c50476e24383bc37755ebcc95627dcbbebde, data reload: false
   
   query1	0.02	0.02	0.02
   query2	0.05	0.03	0.02
   query3	0.24	0.05	0.04
   query4	1.83	0.06	0.07
   query5	0.53	0.52	0.52
   query6	1.23	0.61	0.61
   query7	0.01	0.01	0.02
   query8	0.04	0.03	0.02
   query9	0.53	0.49	0.48
   query10	0.53	0.54	0.53
   query11	0.11	0.08	0.09
   query12	0.11	0.09	0.09
   query13	0.61	0.62	0.61
   query14	0.78	0.78	0.77
   query15	0.78	0.76	0.75
   query16	0.38	0.37	0.37
   query17	1.00	1.03	0.98
   query18	0.22	0.25	0.26
   query19	1.86	1.81	1.86
   query20	0.02	0.02	0.01
   query21	15.46	0.57	0.56
   query22	1.94	2.01	1.52
   query23	17.42	0.86	0.95
   query24	5.70	2.46	1.08
   query25	1.47	0.11	0.10
   query26	0.36	0.14	0.13
   query27	0.11	0.11	0.11
   query28	6.92	0.73	0.71
   query29	12.65	2.38	2.32
   query30	0.60	0.53	0.52
   query31	2.83	0.38	0.38
   query32	3.41	0.49	0.50
   query33	3.09	3.10	3.10
   query34	15.26	4.81	4.80
   query35	4.84	4.85	4.86
   query36	1.05	1.01	1.01
   query37	0.06	0.04	0.05
   query38	0.04	0.02	0.02
   query39	0.02	0.01	0.02
   query40	0.16	0.14	0.13
   query41	0.06	0.02	0.01
   query42	0.02	0.01	0.01
   query43	0.02	0.02	0.01
   Total cold run time: 104.37 s
   Total hot run time: 30.8 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1923829626

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30739:
URL: https://github.com/apache/doris/pull/30739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922739988

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 49693 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c8c5c50476e24383bc37755ebcc95627dcbbebde, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17743	4340	4374	4340
   q2	2045	151	141	141
   q3	10277	1913	1885	1885
   q4	10288	1223	1308	1223
   q5	8441	3900	4029	3900
   q6	230	123	126	123
   q7	2123	1608	1620	1608
   q8	9556	2693	2709	2693
   q9	13843	10632	10344	10344
   q10	8641	3497	3537	3497
   q11	414	244	243	243
   q12	466	293	313	293
   q13	18344	3978	4082	3978
   q14	341	324	314	314
   q15	507	463	456	456
   q16	688	600	586	586
   q17	1124	932	916	916
   q18	7355	6893	6946	6893
   q19	1686	1552	1510	1510
   q20	548	309	312	309
   q21	4407	4043	4057	4043
   q22	515	398	398	398
   Total cold run time: 119582 ms
   Total hot run time: 49693 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4367	4337	4302	4302
   q2	320	222	220	220
   q3	4121	4173	4139	4139
   q4	2730	2737	2735	2735
   q5	7236	7230	7229	7229
   q6	238	119	119	119
   q7	3252	2856	2766	2766
   q8	4376	4468	4464	4464
   q9	17075	16987	16887	16887
   q10	4202	4210	4253	4210
   q11	792	652	672	652
   q12	1049	837	838	837
   q13	6804	3761	3714	3714
   q14	444	408	425	408
   q15	498	455	454	454
   q16	783	703	702	702
   q17	3804	3910	3818	3818
   q18	8823	8873	8713	8713
   q19	1716	1660	1701	1660
   q20	2370	2146	2170	2146
   q21	8465	8466	8448	8448
   q22	1036	969	926	926
   Total cold run time: 84501 ms
   Total hot run time: 79549 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922812346

   run fe_ut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922711912

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922713151

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1923829567

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922750840

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 241608 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c8c5c50476e24383bc37755ebcc95627dcbbebde, data reload: false
   
   query1	930	423	405	405
   query2	6517	2220	2132	2132
   query3	6911	205	202	202
   query4	20189	18031	18144	18031
   query5	19724	6339	6291	6291
   query6	274	213	230	213
   query7	4151	310	297	297
   query8	253	288	259	259
   query9	3065	2640	2588	2588
   query10	400	287	307	287
   query11	11370	10618	10818	10618
   query12	120	77	74	74
   query13	5668	661	632	632
   query14	18083	13430	13677	13430
   query15	389	248	235	235
   query16	6486	263	262	262
   query17	3233	904	907	904
   query18	3478	425	423	423
   query19	209	149	154	149
   query20	80	83	76	76
   query21	183	96	100	96
   query22	5311	5108	5055	5055
   query23	33778	32983	33084	32983
   query24	7499	6585	6564	6564
   query25	540	417	417	417
   query26	501	171	158	158
   query27	1758	300	302	300
   query28	6018	2241	2208	2208
   query29	2943	2725	2846	2725
   query30	249	171	174	171
   query31	913	737	729	729
   query32	64	61	57	57
   query33	396	264	255	255
   query34	868	484	499	484
   query35	1122	905	916	905
   query36	1432	1492	1550	1492
   query37	86	62	59	59
   query38	3145	2943	2944	2943
   query39	1388	1325	1335	1325
   query40	204	102	100	100
   query41	36	37	32	32
   query42	80	90	96	90
   query43	615	599	646	599
   query44	1135	712	715	712
   query45	245	230	227	227
   query46	1241	976	976	976
   query47	1913	1792	1936	1792
   query48	983	680	674	674
   query49	617	379	370	370
   query50	865	583	663	583
   query51	5656	5490	5483	5483
   query52	88	99	72	72
   query53	443	334	307	307
   query54	2480	2253	2255	2253
   query55	89	78	77	77
   query56	235	209	188	188
   query57	1166	1124	1151	1124
   query58	213	200	208	200
   query59	3607	3069	3094	3069
   query60	217	203	213	203
   query61	87	86	88	86
   query62	868	496	449	449
   query63	481	331	331	331
   query64	1992	1341	1289	1289
   query65	3770	3657	3690	3657
   query66	808	374	356	356
   query67	16237	15794	16114	15794
   query68	8276	669	679	669
   query69	548	337	358	337
   query70	1924	1961	1773	1773
   query71	411	313	306	306
   query72	4508	3313	3408	3313
   query73	737	330	332	330
   query74	6377	5816	5789	5789
   query75	4437	3582	3539	3539
   query76	4725	1201	1217	1201
   query77	564	242	254	242
   query78	33399	51175	48705	48705
   query79	14581	661	652	652
   query80	4246	386	390	386
   query81	579	243	242	242
   query82	1083	97	103	97
   query83	326	139	127	127
   query84	256	69	70	69
   query85	1692	284	282	282
   query86	454	374	381	374
   query87	3346	3054	3036	3036
   query88	6856	2356	2323	2323
   query89	402	275	279	275
   query90	2503	208	217	208
   query91	153	124	129	124
   query92	65	53	52	52
   query93	4120	611	594	594
   query94	1659	205	210	205
   query95	1115	1037	1052	1037
   query96	632	335	333	333
   query97	6507	6397	6441	6397
   query98	198	179	166	166
   query99	3686	926	898	898
   Total cold run time: 346460 ms
   Total hot run time: 241608 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922757128

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit c8c5c50476e24383bc37755ebcc95627dcbbebde with default session variables
   Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map [doris]

Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #30739:
URL: https://github.com/apache/doris/pull/30739#issuecomment-1922811840

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org