You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/16 03:14:43 UTC

[GitHub] [spark] caican00 opened a new pull request #35867: [SPARK-38559][SQL][WEBUI]Display the number of empty partitions on spark ui

caican00 opened a new pull request #35867:
URL: https://github.com/apache/spark/pull/35867


   ### What changes were proposed in this pull request?
   Display the number of empty partitions on spark ui when demoting join from broadcast-hash to smj.
   
   Before updated the ui:
   ![image](https://user-images.githubusercontent.com/94670132/158509404-2feacfbd-0c40-405a-8097-586befc95d74.png)
   After updated the ui, display the number of empty partitions:
   ![image](https://user-images.githubusercontent.com/94670132/158509432-4f0a4adf-e8d3-4f40-8f31-89e0340bccf0.png)
   
   
   ### Why are the changes needed?
   When demoting join from broadcast-hash to smj, i think it is necessary to display the number of empty partitions on spark ui.
   Otherwise, users might wonder why SMJ is used when joining a small table. Displaying the number of empty partitions is useful for users to understand changes to the execution plan.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] caican00 commented on pull request #35867: [SPARK-38559][SQL][WEBUI]Display the number of empty partitions on spark ui

Posted by GitBox <gi...@apache.org>.
caican00 commented on pull request #35867:
URL: https://github.com/apache/spark/pull/35867#issuecomment-1068690686


   @cloud-fan Hi, could you help to review this pr? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] caican00 commented on pull request #35867: [SPARK-38559][SQL][WEBUI]Display the number of empty partitions on spark ui

Posted by GitBox <gi...@apache.org>.
caican00 commented on pull request #35867:
URL: https://github.com/apache/spark/pull/35867#issuecomment-1074783751


   friendly ping @JkSelf Hi, could you review this pr for me? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] caican00 commented on pull request #35867: [SPARK-38559][SQL][WEBUI]Display the number of empty partitions on spark ui

Posted by GitBox <gi...@apache.org>.
caican00 commented on pull request #35867:
URL: https://github.com/apache/spark/pull/35867#issuecomment-1068696808


   cc @JkSelf 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35867: [SPARK-38559][SQL][WEBUI]Display the number of empty partitions on spark ui

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35867:
URL: https://github.com/apache/spark/pull/35867#issuecomment-1071270448


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35867: [SPARK-38559][SQL][WEBUI]Display the number of empty partitions on spark ui

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35867:
URL: https://github.com/apache/spark/pull/35867#issuecomment-1071270448


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org