You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Qian Xu <qi...@intel.com> on 2015/05/03 05:08:08 UTC
Re: Review Request 33252: SQOOP-2306 Sqoop2: Generic JDBC: Use
LinkConfiguration in Executor rather then LinkConfig
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33252/#review82331
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Xu
On April 16, 2015, 9:07 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33252/
> -----------------------------------------------------------
>
> (Updated April 16, 2015, 9:07 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2306
> https://issues.apache.org/jira/browse/SQOOP-2306
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've changed the API to use the LinkConfiguration instead of LinkConfig as mentioned on the JIRA.
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java a5cd715
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExtractor.java 63046c0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java df517bd
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java 22b726e
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToDestroyer.java b9f7e7f
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java c2515a5
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java 01e77a3
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java 5a5e9ce
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java dd6bb27
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java c80fd32
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java 3a73691
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java 17bac77
>
> Diff: https://reviews.apache.org/r/33252/diff/
>
>
> Testing
> -------
>
> Seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>