You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/07/14 13:58:53 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3652: ARTEMIS-3384 Fix bridge duplicate messages after reconnection
brusdev opened a new pull request #3652:
URL: https://github.com/apache/activemq-artemis/pull/3652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3652: ARTEMIS-3384 Fix bridge duplicate messages after reconnection
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3652:
URL: https://github.com/apache/activemq-artemis/pull/3652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3652: ARTEMIS-3384 Fix bridge duplicate messages after reconnection
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3652:
URL: https://github.com/apache/activemq-artemis/pull/3652#discussion_r670551056
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PersistentDuplicateIDCache.java
##########
@@ -240,6 +242,7 @@ private synchronized void addToCache(final ByteArray holder,
}
if (instantAdd) {
+ addToCacheInMemory(holder, recordID);
Review comment:
I don't get it.. wouldn't this be either in TX or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3652: ARTEMIS-3384 Fix bridge duplicate messages after reconnection
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3652:
URL: https://github.com/apache/activemq-artemis/pull/3652#discussion_r670591316
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PersistentDuplicateIDCache.java
##########
@@ -240,6 +242,7 @@ private synchronized void addToCache(final ByteArray holder,
}
if (instantAdd) {
+ addToCacheInMemory(holder, recordID);
Review comment:
yes but it isn't executed by TX if instantAdd = true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org