You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/23 18:21:36 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #28562: Rerun flaky PinotDB integration test
Taragolis opened a new pull request, #28562:
URL: https://github.com/apache/airflow/pull/28562
Time to time we have this error on public runner.
```console
self = <tests.integration.providers.apache.pinot.hooks.test_pinot.TestPinotDbApiHookIntegration object at 0x7f36f132d450>
@mock.patch.dict("os.environ", AIRFLOW_CONN_PINOT_BROKER_DEFAULT="pinot://pinot:8000/")
def test_should_return_records(self):
hook = PinotDbApiHook()
sql = "select playerName from baseballStats ORDER BY playerName limit 5"
records = hook.get_records(sql)
> assert [["A. Harry"], ["A. Harry"], ["Aaron"], ["Aaron Albert"], ["Aaron Albert"]] == records
E AssertionError: assert [['A. Harry']...aron Albert']] == []
E Left contains 5 more items, first extra item: ['A. Harry']
E Use -v to get the full diff
tests/integration/providers/apache/pinot/hooks/test_pinot.py:34: AssertionError
```
Most probably the nature of this error some kind of race condition:
1. PinotDB test service marked healthy before data actually persist into test database
2. Test get 0 record as result test failed.
In case of failure test will rerun after 30 seconds but only once.
In additional I remove [flaky](https://pypi.org/project/flaky/) as dev-dependency because it use the same marker `@pytest.mark.flaky` as [pytest-rerunfailures](https://github.com/pytest-dev/pytest-rerunfailures) plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28562: Rerun flaky PinotDB integration test
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28562:
URL: https://github.com/apache/airflow/pull/28562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org