[GitHub] [hive] vcsomor commented on a change in pull request #2974: HIVE-25746 Fix of Compaction Failure Counter counted incorrectly

[GitBox <gi...@apache.org>]

vcsomor commented on a change in pull request #2974:
URL: https://github.com/apache/hive/pull/2974#discussion_r792584766



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java
##########
@@ -128,9 +132,40 @@ protected static long updateCycleDurationMetric(String metric, long startedAt) {
       long elapsed = System.currentTimeMillis() - startedAt;
       LOG.debug("Updating {} metric to {}", metric, elapsed);
       Metrics.getOrCreateGauge(metric)
-          .set((int)elapsed);
+          .set((int) elapsed);
       return elapsed;
     }
     return 0;
   }
+
+  @VisibleForTesting
+  protected static void waitAllAsyncTask(List<CompletableFuture<Void>> tasks) throws AsyncTaskCompletionException {
+    List<Throwable> exceptions = new ArrayList<>();
+    for (CompletableFuture<Void> task : tasks) {
+      try {
+        task.join();

Review comment:
       Which thread safe list implementation do you prefer in this case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org