[jira] [Comment Edited] (HBASE-15441) Fix WAL splitting when region has moved multiple times

["Elliott Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193771#comment-15193771 ] 

Elliott Clark edited comment on HBASE-15441 at 3/14/16 6:24 PM:
----------------------------------------------------------------

Yea, it sure seems like the close isn't needed at all.
It tries to:
* clean the cache ( something that warmup shouldn't be doing anyway ).
* Flush all edit ( there should be no edits ever ).
* Disable all compactions ( there are no compactions running since this is read only).



was (Author: eclark):
Yea, it sure seems like the close isn't needed at all.
It tries to:
* clean the cache ( something that warmup shouldn't be doing anyway ).
* Flush all edit ( there should be no edits ever ).
* Disable all compactions ( there are no compactions running since this is


> Fix WAL splitting when region has moved multiple times
> ------------------------------------------------------
>
>                 Key: HBASE-15441
>                 URL: https://issues.apache.org/jira/browse/HBASE-15441
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.1.0, 1.2.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Blocker
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-15441-v1.patch, HBASE-15441-v2.patch, HBASE-15441.patch
>
>
> Currently WAL splitting is broken when a region has been opened multiple times in recent minutes.
> Region open and region close write event markers to the wal. These markers should have the sequence id in them. However it is currently getting 1. That means that if a region has moved multiple times in the last few mins then multiple split log workers will try and create the recovered edits file for sequence id 1. One of the workers will fail and on failing they will delete the recovered edits. Causing all split wal attempts to fail.
> We need to:
> # make sure that close get the correct sequence id for open.
> # Filter all region events from recovered edits
> It appears that the close event with a sequence id of one is coming from region warm up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)