[jira] [Commented] (SLING-4352) The ResourceResolver passed to SlingScripts should not be closeable

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680091#comment-14680091 ] 

Carsten Ziegeler commented on SLING-4352:
-----------------------------------------

I think this is also true for the RR passed to SlingScript/ScriptContext in general. So I have the feeling that we maybe should solve this in a general solution in DefaultSlingScript.

> The ResourceResolver passed to SlingScripts should not be closeable
> -------------------------------------------------------------------
>
>                 Key: SLING-4352
>                 URL: https://issues.apache.org/jira/browse/SLING-4352
>             Project: Sling
>          Issue Type: Bug
>          Components: Servlets
>            Reporter: Radu Cotescu
>             Fix For: Servlets Resolver 2.3.8
>
>
> The {{SlingServletResolver}} uses an administrative resource resolver ({{sharedScriptResolver}}) for script resolution. This same resolver is passed to SlingScripts when a resource is adapted to a {{SlingScript}} in {{SlingServletResolver#findScript}} (see {{SlingScriptAdapterFactory#getAdapter}}).
> Since this resolver is made available to scripts in the {{ScriptContext}} (see the implementation of {{DefaultSlingScript#call}}), the resolver should be protected against accidental closing from downstream callers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)