You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/07/25 12:04:53 UTC

[GitHub] [zookeeper] amichair commented on pull request #1667: ZOOKEEPER-4271: Flaky test - ReadOnlyModeTest.testConnectionEvents

amichair commented on pull request #1667:
URL: https://github.com/apache/zookeeper/pull/1667#issuecomment-886191923


   I can undo the refactor with a bit of work, but the rename is in a separate commit to make it trivially easy to review... also, it no longer uses a countdown latch, so the name doesn't make sense. Also, it's an implementation detail where before the inner field was accessed directly from outside and is now encapsulated instead, so it makes sense to rename to what it does rather than how it (was) implemented... no?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org