You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andrew Prudhomme (Jira)" <ji...@apache.org> on 2019/09/21 20:40:00 UTC
[jira] [Comment Edited] (CASSANDRA-15310) Fix flakey -
testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTest
[ https://issues.apache.org/jira/browse/CASSANDRA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934136#comment-16934136 ]
Andrew Prudhomme edited comment on CASSANDRA-15310 at 9/21/19 8:39 PM:
-----------------------------------------------------------------------
Looks like the measured time interval does not entirely cover the timeout. The tests in java 11 were sometime falling a few ms short. Adding a fudge factor should help.
edit: On second thought, it is probably better to just refresh the timeout, like in testIdleDisconnectProlonged.
[15310-trunk|https://github.com/aprudhomme/cassandra/commit/bf279fd16960827bb64c39c9d6dc0fe68b067852] [cci_8|https://circleci.com/workflow-run/fc2e076c-fca3-497a-b9aa-db66aa2905f3] [cci_11|https://circleci.com/workflow-run/97c01d17-2ef6-494f-afea-35eba3395350]
was (Author: aprudhomme):
Looks like the measured time interval does not entirely cover the timeout. The tests in java 11 were sometime falling a few ms short. Adding a fudge factor should help.
[15310-trunk|https://github.com/aprudhomme/cassandra/commit/36c9637d7ace8e8ba37db186efe1226e42814c9e] [cci_8|https://circleci.com/workflow-run/5b28d0ed-004a-4823-93ba-aacaf00ff362] [cci_11|https://circleci.com/workflow-run/54c70d11-f45e-44d6-a2c7-3c5948c38939]
> Fix flakey - testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTest
> -----------------------------------------------------------------------------------
>
> Key: CASSANDRA-15310
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15310
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Joseph Lynch
> Assignee: Andrew Prudhomme
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example run: [https://circleci.com/gh/jolynch/cassandra/561#tests/containers/86]
>
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testIdleDisconnect - org.apache.cassandra.transport.IdleDisconnectTestjunit.framework.AssertionFailedError
> at org.apache.cassandra.transport.IdleDisconnectTest.testIdleDisconnect(IdleDisconnectTest.java:56)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org