svn commit: r1494997 - /commons/proper/commons-javadocfix-plugin/trunk/src/main/java/org/apache/commons/plugins/javadocfix/JavadocFixTool.java

[se...@apache.org]

Author: sebb
Date: Thu Jun 20 13:49:28 2013
New Revision: 1494997

URL: http://svn.apache.org/r1494997
Log:
Trivial (style) fixes

Modified:
    commons/proper/commons-javadocfix-plugin/trunk/src/main/java/org/apache/commons/plugins/javadocfix/JavadocFixTool.java

Modified: commons/proper/commons-javadocfix-plugin/trunk/src/main/java/org/apache/commons/plugins/javadocfix/JavadocFixTool.java
URL: http://svn.apache.org/viewvc/commons/proper/commons-javadocfix-plugin/trunk/src/main/java/org/apache/commons/plugins/javadocfix/JavadocFixTool.java?rev=1494997&r1=1494996&r2=1494997&view=diff
==============================================================================
--- commons/proper/commons-javadocfix-plugin/trunk/src/main/java/org/apache/commons/plugins/javadocfix/JavadocFixTool.java (original)
+++ commons/proper/commons-javadocfix-plugin/trunk/src/main/java/org/apache/commons/plugins/javadocfix/JavadocFixTool.java Thu Jun 20 13:49:28 2013
@@ -89,6 +89,7 @@
  * - moved from default package
  * - closed br in replaceStringInFile method. This allows input file to be deleted on Windows
  * - closed br in applyPatch method
+ * - make remaining string constants static and final
  */
 
 package org.apache.commons.plugins.javadocfix;
@@ -107,7 +108,7 @@ public class JavadocFixTool {
                                          "toc.htm"};
 
     // If we locate this function but not validURL - we are in trouble
-    private final String patchString = "function loadFrames() {";
+    private static final String patchString = "function loadFrames() {";
     // Main fix - should be inserted before the loadFrames() function alongside
     // the code that calls this function
     private final static String[] patchData =
@@ -149,11 +150,11 @@ public class JavadocFixTool {
              "    }",
              "    function loadFrames() {"};
 
-    private final String quickFixString = "if (!(url.indexOf(\".html\") == url.length - 5))";
-    private final String[] quickFix = {"        var pos = url.indexOf(\".html\");",
+    private static final String quickFixString = "if (!(url.indexOf(\".html\") == url.length - 5))";
+    private static final String[] quickFix = {"        var pos = url.indexOf(\".html\");",
                                        "        if (pos == -1 || pos != url.length - 5)"};
     private static String readme = null;
-    private static String version = "Java Documentation Updater Tool version 1.2.1 2013-06-19\n";
+    private static final String version = "Java Documentation Updater Tool version 1.2.2 2013-06-20\n";
 
     private static boolean doPatch = true; // By default patch file
     private static boolean recursive = false; // By default only look in the folder in parameter